Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-section-header] Allow sticky header title #4037

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

sugan2416
Copy link
Collaborator

Summary

What was changed:

Allow section header title to be sticky when position is not absolute.

Why it was changed:

  • This change came was introduced to allow headers to be sticky in cases where its position is not fixed/absolute.
  • Issue was identified in a case where flowsheet with sections (terra-section-header) had to be relative when height restricted and had more cells in row. In this scenario, header had to be fixed/sticky to prevent horizontal scroll of header title.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10215


Thank you for contributing to Terra.
@cerner/terra

Copy link
Contributor

@sdadn sdadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this tested?

@github-actions github-actions bot temporarily deployed to preview-pr-4037 February 21, 2024 11:29 Destroyed
@sugan2416
Copy link
Collaborator Author

How was this tested?

Added test and example in 7dd9cf3

@sugan2416 sugan2416 added ⭐ UX Reviewed UX Reviewed and approved. and removed UX Review Required labels Feb 22, 2024
@eawww eawww self-requested a review February 22, 2024 16:32
@sugan2416 sugan2416 merged commit eace3f7 into main Feb 23, 2024
22 checks passed
@sugan2416 sugan2416 deleted the section-header-title-pin branch February 23, 2024 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants