Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-form-select] Add exports for subcomponents #4059

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Mar 11, 2024

Summary

This PR adds proper exports for subcomponents for convenience and to follow standard programming practices. Before, subcomponents/variants had to be imported by specifying the path to the file. e.g.

import Combobox from 'terra-form-select/lib/Combobox';

With these changes, it can now be imported as:

import { Combobox } from 'terra-form-select';

Note:
This is a passive change and simply adds the ability to use the new imports. Consumes using the old style will not be affected.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Mar 11, 2024
@sdadn sdadn requested a review from a team as a code owner March 11, 2024 20:28
@sdadn sdadn merged commit 9ad0577 into main Mar 11, 2024
22 checks passed
@sdadn sdadn deleted the updated-select-imports branch March 11, 2024 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants