This repository has been archived by the owner on May 22, 2024. It is now read-only.
Create skeleton for package-json-lint project #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
requested review from
dkasper-was-taken,
emilyrohrbough,
mjhenkes,
StephenEsser and
tbiethman
as code owners
StephenEsser
approved these changes
Jan 21, 2021
ryanthemanuel
commented
Jan 21, 2021
ryanthemanuel
commented
Jan 21, 2021
ryanthemanuel
commented
Jan 21, 2021
mjhenkes
reviewed
Jan 21, 2021
mjhenkes
reviewed
Jan 21, 2021
Comment on lines
+8
to
+16
| ## Versioning | ||
|
|
||
| package-json-lint is considered to be stable and will follow [SemVer](http://semver.org/) for versioning. | ||
|
|
||
| 1. MAJOR versions represent breaking changes | ||
| 2. MINOR versions represent added functionality in a backwards-compatible manner | ||
| 3. PATCH versions represent backwards-compatible bug fixes | ||
|
|
||
| Consult the component CHANGELOGs, related issues, and PRs for more information. |
There was a problem hiding this comment.
Can this be removed since it's describe at the root level?
There was a problem hiding this comment.
I was mimicking existing packages. As I think about it, it wouldn't show up in the npm page if we didn't include that (if that matters): e.g. https://www.npmjs.com/package/@cerner/terra-cli
| @@ -3,6 +3,7 @@ | |||
| "command": { | |||
| "publish": { | |||
| "ignoreChanges": [ | |||
| "packages/package-json-lint/**", | |||
There was a problem hiding this comment.
Should this be package-json-linter? instead of just lint?
There was a problem hiding this comment.
It's eslint and stylelint not eslinter or stylelinter. I was trying to follow that pattern.
ryanthemanuel
commented
Jan 21, 2021
ryanthemanuel
commented
Jan 21, 2021
ryanthemanuel
commented
Jan 21, 2021
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
mjhenkes
approved these changes
Jan 21, 2021
benbcai
approved these changes
Jan 21, 2021
emilyrohrbough
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is just the initial commit of the package-json-lint project. It is set up not to be released and will be built out as a part of #540
Fixes #538