Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README to include subordinate template for clientAuth #236

Closed
wants to merge 1 commit into from

Conversation

weiwarren
Copy link

Updated document to be consistent with AWS PCA templates. These are important information for users when using CA issuers in k8s in order to generate certificate for mTLS between pods.
https://docs.aws.amazon.com/privateca/latest/userguide/UsingTemplates.html#template-varieties

@jetstack-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 1ef026c Updated README to include subordinate template for clientAuth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiwarren
To complete the pull request process, please assign paramsethi after the PR has been reviewed.
You can assign the PR to them by writing /assign @paramsethi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weiwarren
Copy link
Author

/assign @paramsethi

@bmsiegel
Copy link
Contributor

Hi @weiwarren, this README change is actually incorrect. We map the certmanager usageType to a template in a 1:1 fashion (https://github.com/cert-manager/aws-privateca-issuer/blob/main/pkg/aws/pca.go#L204). We have a feature request to support more path lengths here (#98). Please feel free to reopen or +1 this issue. If you've implemented something for it we're certainly willing to take a look as well!

@bmsiegel
Copy link
Contributor

bmsiegel commented Jan 3, 2023

Closing this PR for now due to no response

@bmsiegel bmsiegel closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants