Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuer/ClusterIssuer support to specify vault token on local filesystem #5437

Closed
andrejvanderzee opened this issue Sep 15, 2022 · 5 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@andrejvanderzee
Copy link

andrejvanderzee commented Sep 15, 2022

The documentation https://cert-manager.io/v0.16-docs/configuration/vault/ sais:

cert-manager does not refresh these token automatically and so another process must be put in place to do this.

Can I suggest an option auth.vaultTokenPath on local filesystem as an alternative for auth.tokenSecretRef? Then we can use a Vault sidecar that takes care of token refreshes in a shared volume mount with the cert-manager container. https://www.vaultproject.io/docs/platform/k8s/injector

@andrejvanderzee andrejvanderzee changed the title Issuer/ClusterIssuer support to specify vault token location Issuer/ClusterIssuer support to specify vault token on local filesystem Sep 15, 2022
@andrejvanderzee
Copy link
Author

Anybody? This looks like a flawed implementation ending up with an orphaned vault token with high TTL or some custom side-car implementation that updated the Kubernetes secret with refreshed Vault token and restarts cert-manager.

@jetstack-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2023
@jetstack-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

@jetstack-bot jetstack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 23, 2023
@jetstack-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

@jetstack-bot
Copy link
Contributor

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

2 participants