Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'status' subresource on CRDs #1922

Closed
wants to merge 3 commits into from
Closed

Enable 'status' subresource on CRDs #1922

wants to merge 3 commits into from

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Jul 23, 2019

What this PR does / why we need it:

This patches enables the 'status' subresource on our CRDs and switches the controllers over to use UpdateStatus instead of Update.

This has been supported in Kubernetes since v1.8 or v1.9, and enabled by default (i.e. on GKE etc) since 1.10.

Given that Kubernetes 1.11 is now the oldest supported version (as of 1.15 being recently released), we are now 6mths clear of EOL for k8s 1.9. I think it's now probably safe to switch this and break compatibility with Kubernetes 1.9 (making our minimum supported version 1.10).

Release note:

Enable 'status' subresource on cert-manager CRDs (this change bumps the minimum supported Kubernetes version to 1.10)

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jul 23, 2019
@jetstack-bot jetstack-bot added the area/acme Indicates a PR directly modifies the ACME Issuer code label Jul 23, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2019
@munnerz munnerz added this to the v0.10 milestone Jul 23, 2019
ellieayla
ellieayla reviewed Jul 23, 2019
View reviewed changes
docs/getting-started/install/kubernetes.rst
.. note::
From cert-manager v0.10.0 onwards, the minimum supported version of
Kubernetes is v1.10.0. Users still running Kubernetes 1.9 or below should
upgrade to a supported version before installing cert-manager.
Copy link

@ellieayla ellieayla Jul 23, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad this text is here. It possibly missing was the only part of this PR that had me worried. :)

@munnerz
Copy link
Member Author

munnerz commented Jul 24, 2019

/retest

@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2019
@munnerz
Copy link
Member Author

munnerz commented Jul 24, 2019

/retest

1 similar comment
@munnerz
Copy link
Member Author

munnerz commented Jul 24, 2019

/retest

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2019
@JoshVanL
Copy link
Collaborator

@munnerz needs rebase
/unassign
/assign @munnerz

@jetstack-bot jetstack-bot assigned munnerz and unassigned JoshVanL Jul 31, 2019
@munnerz
Enable 'status' subresource on CRDs
2ee2676 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2019
@munnerz
Update tests to check for UpdateStatus calls
d32d28c 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Add omitempty to spec and status fields
3977289 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz munnerz mentioned this pull request Aug 2, 2019
Merged
@munnerz
Copy link
Member Author

munnerz commented Aug 2, 2019

/retest

1 similar comment
@munnerz
Copy link
Member Author

munnerz commented Aug 2, 2019

/retest

@munnerz munnerz modified the milestones: v0.10, Next Aug 16, 2019
@munnerz
Copy link
Member Author

munnerz commented Aug 21, 2019

/test pull-cert-manager-e2e-v1-15

@jetstack-bot
Copy link
Contributor

@munnerz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cert-manager-e2e-v1-13 3977289 link /test pull-cert-manager-e2e-v1-13
pull-cert-manager-e2e-v1-15 3977289 link /test pull-cert-manager-e2e-v1-15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@munnerz munnerz modified the milestones: Next, v0.11 Sep 7, 2019
@munnerz
Copy link
Member Author

munnerz commented Sep 23, 2019

Closing in favour of #2097

@munnerz munnerz closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellieayla ellieayla ellieayla left review comments

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@munnerz @jetstack-bot @JoshVanL @ellieayla