Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add omitempty to spec and status fields #1957

Merged
merged 1 commit into from Aug 2, 2019
Merged

Add omitempty to spec and status fields #1957

merged 1 commit into from Aug 2, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Aug 2, 2019

What this PR does / why we need it:

Pulled out of #1922 so it can be cherry-picked back to v0.9.

Release note:

Mark 'spec' and 'status' as non-required fields in CRDs

@munnerz
Add omitempty to spec and status fields
987967c 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/api Indicates a PR directly modifies the 'pkg/apis' directory labels Aug 2, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/deploy Indicates a PR modifies deployment configuration approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2019
@munnerz
Copy link
Member Author

munnerz commented Aug 2, 2019

/retest

@JoshVanL
Copy link
Collaborator

JoshVanL commented Aug 2, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2019
@jetstack-bot jetstack-bot merged commit 7575e26 into cert-manager:master Aug 2, 2019
@munnerz munnerz deleted the fixup-req-status branch August 2, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@munnerz @jetstack-bot @JoshVanL