-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write CRD filter for OpenShift #2609
Conversation
This adds a Go binary that filters certain keys from the CRDs. This is meant to remove keys that are not compatible with OpenShift 3.11. This then is ran on creating the deployment manifests. Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, LGTM otherwise!
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This adds a Go binary that filters certain keys from the CRDs.
This is meant to remove keys that are not compatible with OpenShift 3.11.
This then is used on creating the deployment manifests.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes #2200
Special notes for your reviewer:
Release note: