-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default deployment namespace to be 'cert-manager' #330
Update default deployment namespace to be 'cert-manager' #330
Conversation
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/hold |
Holding this until we've updated it to also make changing leader election namespace and cluster resource namespace easy too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but one question.
The docs suggest installing cert manager in kube-system:
Why not make that the default?
@wallrj #329 is also switching the default cluster namespace be that of the cert-manager pod. I was generally trying to move towards cert-manager self contained in a single namespace (including the leader election configmap too). I've held this PR, in order to update the docs & other places to do this, as merging now would cause a mixture of kube-system and the pods namespace to be used by default which is a bit messy. |
LGTM. Thanks |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Previously, our deployment manifests deployed into the 'default' namespace. This changes them to deploy into 'cert-manager' instead.
Release note: