Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default deployment namespace to be 'cert-manager' #330

Merged

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Feb 22, 2018

What this PR does / why we need it:

Previously, our deployment manifests deployed into the 'default' namespace. This changes them to deploy into 'cert-manager' instead.

Release note:

The static deployment manifests now automatically deploy into the 'cert-manager' namespace by default

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2018
@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2018

/retest

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2018

/retest

@munnerz munnerz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 22, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2018

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2018
@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2018

Holding this until we've updated it to also make changing leader election namespace and cluster resource namespace easy too.

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one question.

The docs suggest installing cert manager in kube-system:

Why not make that the default?

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2018

@wallrj #329 is also switching the default cluster namespace be that of the cert-manager pod. I was generally trying to move towards cert-manager self contained in a single namespace (including the leader election configmap too).

I've held this PR, in order to update the docs & other places to do this, as merging now would cause a mixture of kube-system and the pods namespace to be used by default which is a bit messy.

@munnerz munnerz removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 22, 2018
@davecheney
Copy link

LGTM. Thanks

@munnerz munnerz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 22, 2018
@jetstack-ci-bot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@jetstack-ci-bot
Copy link
Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@jetstack-ci-bot jetstack-ci-bot merged commit 09c6a09 into cert-manager:master Feb 22, 2018
@munnerz munnerz deleted the namespaced-deploy-manifests branch January 29, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants