Set default cluster resource namespace to current pod namespace

[munnerz]

What this PR does / why we need it:

Changes the default cluster resource namespace from kube-system to the current namespace of the cert-manager deployment.

Which issue this PR fixes: fixes #103

Release note:

Supporting resources for ClusterIssuer's (e.g. signing CA certificates, or ACME account private keys) will now be stored in the same namespace as cert-manager, instead of kube-system in previous versions. Action required: you will need to ensure to properly manually migrate these referenced resources across into the deployment namespace of cert-manager, else cert-manager may not be able to find account private keys or signing CA certificates.

/cc @mikebryant

[jetstack-bot]

@munnerz: GitHub didn't allow me to request PR reviews from the following users: mikebryant.

Note that only jetstack members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

Changes the default cluster resource namespace from kube-system to the current namespace of the cert-manager deployment.

Which issue this PR fixes: fixes #103

Release note:

Supporting resources for ClusterIssuer's (e.g. signing CA certificates, or ACME account private keys) will now be stored in the same namespace as cert-manager, instead of kube-system in previous versions. Action required: you will need to ensure to properly manually migrate these referenced resources across into the deployment namespace of cert-manager, else cert-manager may not be able to find account private keys or signing CA certificates.

/cc @mikebryant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[munnerz]

/retest

[wallrj]

I can't see anywhere in the diff that we create the cert-manager namespace.

If it's created elsewhere, should that be using the new constant too?

The 1.8 tests failed with:

I0222 09:02:41.027] NAME                       DESIRED   CURRENT   READY     AGE
I0222 09:02:41.027] nginx-ingress-controller   1         1         1         2m
W0222 09:02:41.308] The Service "nginx-ingress-controller" is invalid: spec.clusterIP: Invalid value: "10.0.0.15": provided IP is already allocated

Is that a test flake?

The 1.9 e2e tests failed with an actual test error, but I'm not yet familiar enough with the code to understand the failure message.

[munnerz]

@wallrj Helm automatically creates the namespace before deploying. For the static manifests, a user will need to run kubectl create namespace cert-manager first.

[munnerz]

Regarding the test - yep that's a flake that can happen when lots of VMs are starting at once 😢

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[jetstack-ci-bot]

/lgtm cancel //PR changed after LGTM, removing LGTM. @munnerz

[munnerz]

/retest

[jetstack-ci-bot]

/test all [submit-queue is verifying that this PR is safe to merge]

[jetstack-ci-bot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.