Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a meaningful User-Agent. #422

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Add a meaningful User-Agent. #422

merged 2 commits into from
Apr 4, 2018

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Mar 30, 2018 •
edited by munnerz

Related to #407.

Add a meaningful user agent to the ACME client to help diagnosing abusive traffic patterns

@jetstack-bot jetstack-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2018
munnerz
munnerz reviewed Mar 31, 2018
View reviewed changes
Copy link
Member

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll cherry pick this into 0.2 as well once merged. Thanks for putting this together.

pkg/issuer/acme/acme.go Outdated
ua string
}

const Version = "v0.2.3"
Copy link
Member

@munnerz munnerz Mar 31, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use pkg/util.AppVersion here instead to save it being maintained in multiple places

@munnerz
Copy link
Member

munnerz commented Mar 31, 2018

/ok-to-test

@jetstack-bot jetstack-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2018
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 4, 2018
@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

@jsha I've updated your PR with an additional commit to fix test failures, as well as using util.AppVersion for generating the user agent to use.

Thanks for this PR - I'll get this cherry picked into release 0.2 once merged, and this will be the final PR to go into 0.2 😄.

#309 will also switch us to use acmev2, and will also encompass this change 😄. I'll be cutting 0.3-alpha.1 later today hopefully, and I'd imagine a number of users should be willing to test it out on account of wildcard cert support, so we should get some data back 😄

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2018
@munnerz munnerz added this to the v0.2 milestone Apr 4, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2018
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

Seems we're hitting a test flake when boulder is installed. It appears to be happening everywhere now too 🤔 I'll investigate further. I think it's due to a lack of resources on our build cluster.

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

/retest

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@munnerz munnerz mentioned this pull request Apr 4, 2018
Closed
@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

/retest

@jetstack-bot jetstack-bot merged commit 8a1b008 into cert-manager:master Apr 4, 2018
@munnerz munnerz mentioned this pull request Apr 4, 2018
Merged
jetstack-bot added a commit that referenced this pull request Apr 4, 2018
@jetstack-bot
Merge pull request #430 from munnerz/automated-cherry-pick-of-#422-up…
3223348 
…stream-release-0.2

Automated cherry pick of #422
@euank euank mentioned this pull request Apr 4, 2018
Merged
wallrj added a commit to wallrj/cert-manager that referenced this pull request Mar 20, 2024
@wallrj
An http.RoundTripper which adds the HTTP User-Agent header to all req…
112c7b2 
…uests

This code existed in cert-manager once before and I'm reviving it.
Here's the history:

 * Added:
 cert-manager#422
 * Moved: cert-manager#432
 * Obsoleted: cert-manager#797
 * Deleted: cert-manager#966

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj wallrj mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsha @munnerz @jetstack-bot @retest-bot