Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] Regression: restore the previous service type defaulting behaviour #4394

Merged
merged 3 commits into from
Aug 19, 2021
Merged

[release-1.5] Regression: restore the previous service type defaulting behaviour #4394

merged 3 commits into from
Aug 19, 2021

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #4393

/assign jakexks

Fixed the HTTP-01 solver creating ClusterIP instead of NodePort services by default.

@jakexks
Fix regression in solver service builder - default service type shoul…
ff95b89 
…d be NodePort rather than empty

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jakexks
Add integration test for ensuring default solver service type is Node…
90f8307 
…Port

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jakexks
Update Docs on solver type to reflect default service type
1d83c2e 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jetstack-bot jetstack-bot mentioned this pull request Aug 19, 2021
Merged
@jetstack-bot jetstack-bot added this to the v1.5 milestone Aug 19, 2021
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2021
jakexks
jakexks approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, jetstack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@jakexks
Copy link
Member

jakexks commented Aug 19, 2021

/kind bug

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 19, 2021
@jakexks jakexks added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 19, 2021
@jetstack-bot jetstack-bot merged commit 375c564 into cert-manager:release-1.5 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jetstack-bot @jakexks