Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add leaderElection.namespace option to helm chart #548

Merged
merged 2 commits into from
May 11, 2018
Merged

Add leaderElection.namespace option to helm chart #548

merged 2 commits into from
May 11, 2018

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented May 9, 2018

What this PR does / why we need it:

Previously, a ConfigMap in the kube-system namespace was used to perform leader election. This updates the chart to use the same namespace as cert-manager is deployed into for leader election.

Release note:

Use cert-manager deployment namespace by default for leader election

@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2018
@jetstack-bot jetstack-bot requested a review from kragniz May 9, 2018 15:58
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2018
@munnerz munnerz added this to the v0.3 milestone May 9, 2018
@munnerz munnerz added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label May 9, 2018
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

20 similar comments
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@munnerz
Copy link
Member Author

munnerz commented May 10, 2018

Cancelling lgtm to save retests until LE staging outage is resolved this evening

/lgtm cancel

@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2018
@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label May 11, 2018
@munnerz
Copy link
Member Author

munnerz commented May 11, 2018

/retest

1 similar comment
@munnerz
Copy link
Member Author

munnerz commented May 11, 2018

/retest

@jetstack-bot jetstack-bot merged commit 0bf3ff6 into cert-manager:master May 11, 2018
munnerz added a commit to munnerz/charts-1 that referenced this pull request May 24, 2018
@munnerz
cert-manager: fast-forward to upstream 1e606b3e
4c04b32 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
@munnerz munnerz mentioned this pull request May 24, 2018
Merged
k8s-ci-robot pushed a commit to helm/charts that referenced this pull request May 24, 2018
@munnerz @k8s-ci-robot
cert-manager: fast-forward to upstream 1e606b3e (#5744)
cc8e3fd 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
cesaralbloz pushed a commit to cesaralbloz/charts that referenced this pull request May 25, 2018
@munnerz
cert-manager: fast-forward to upstream 1e606b3e (helm#5744)
ff48906 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
@munnerz @or1can
cert-manager: fast-forward to upstream 1e606b3e (helm#5744)
f416fe8 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
@munnerz
cert-manager: fast-forward to upstream 1e606b3e (helm#5744)
aa3bc39 
* Bump chart and manifests for v0.3.0 release (cert-manager/cert-manager#575)
* add pod labels (cert-manager/cert-manager#563)
* Add leaderElection.namespace option to helm chart (cert-manager/cert-manager#548)
* Add clusterResourceNamespace option to Helm chart (cert-manager/cert-manager#547)
* Fix ingress-shim cli flags (cert-manager/cert-manager#526)
* Create chart OWNERS (cert-manager/cert-manager#528)
* Link ingress-shim into main controller binary (cert-manager/cert-manager#502)
* readthedocs documentation rewrite (cert-manager/cert-manager#428)
* add selector, as otherwise it fails on GKE k8s v1.9.x (cert-manager/cert-manager#440)
* Add podAnnotations (cert-manager/cert-manager#387)
* Document common ingressShim.extraArgs use case in chart (cert-manager/cert-manager#382)
* Helm Chart: Add support for affinity and tolerations (cert-manager/cert-manager#350)
* Set default cluster resource namespace to current pod namespace (cert-manager/cert-manager#329)
* Create a Namespace resource as part of the static manifest bundle (cert-manager/cert-manager#340)
* Add default shortNames to certificates CRD (cert-manager/cert-manager#312)
* fix: Use ConfigMaps for leaderelection (cert-manager/cert-manager#327)

Signed-off-by: voron <av@arilot.com>
@munnerz munnerz deleted the leaderelectns branch January 29, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz Awaiting requested review from kragniz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@munnerz @jetstack-bot @retest-bot