feat: add tls to metrics endpoint #6574

ThatsMrTalbot · 2023-12-27T17:22:16Z

Pull Request Motivation

Add TLS support to the metrics endpoint using the same mechanism the webhook uses to create/manage certificates.

This moves the logic for CertificateSources out of the webhook package and into a "server" package that is consumed by both the webook server and the metrics server.

I originally attempted to pull out the TLSConfig struct into a common package, but that led me down conversion-gen rabbit hole that got overly complex.

TODO:

Add tests for new options
Update website (will be done in another PR)
Update helm chart

Fixes #6558

Kind

feature

Release Note

Add TLS support to metrics endpoint through either certificate file or dynamically issued cert

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot · 2024-01-02T13:30:25Z

Since the config can be done via a config file, this does not need any changes to the helm charts.

… chart Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot · 2024-01-02T15:43:52Z

/retest

ThatsMrTalbot · 2024-01-02T16:09:44Z

Added some validation tests

wallrj · 2024-01-04T14:18:18Z

/kind feature
/milestone 1.14

wallrj

Some comments and suggestions after a first skim through the code.

pkg/server/listener.go

cmd/controller/app/controller.go

internal/apis/config/controller/types.go

internal/apis/config/controller/validation/validation.go

pkg/apis/config/controller/v1alpha1/types.go

wallrj · 2024-01-04T15:13:41Z

Update website (will be done in another PR)

@ThatsMrTalbot Please create a draft website PR so that I can know how to test this feature and so that @eanveden can tell us whether this will meet his needs.

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot · 2024-01-04T16:22:51Z

Raised cert-manager/website#1376 for updating the website

wallrj

I left some comments and questions in the documentation PR.

wallrj · 2024-01-08T17:25:33Z

internal/server/tls/dynamic_source.go

This file still logs "webhook" specific messages.

$ kubectl -n cert-manager logs deployments/cert-manager | grep webhook I0108 17:19:50.822405 1 dynamic_source.go:255] "cert-manager/controller: Updated cert-manager webhook TLS certificate" DNSNames=["cert-manager-metrics","cert-manager-metrics.cert-manager","cert-manager-metrics.cert-manager.svc"]

I have corrected the log line

wallrj · 2024-01-10T14:32:11Z

@ThatsMrTalbot I've managed to test this now using the website instructions and it seems to work well.

Please just address that misleading "webhook" log message and then I'll add an lgtm and we can include this in the next alpha release, so that it can be tested by more people.

Thanks.

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

wallrj

/lgtm
/approve

jetstack-bot · 2024-01-10T14:45:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wallrj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://github.com/cert-manager/cert-manager) | minor | `v1.13.3` -> `v1.14.1` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.14.1`](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.1) [Compare Source](cert-manager/cert-manager@v1.14.0...v1.14.1) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. > 📢 cert-manager `v1.14.1` fixes bugs found *during* the release of `v1.14.0`. > > When upgrading to cert-manager release 1.14, please skip `v1.14.0` and install this patch version instead. ##### Documentation - [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) - [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) - [Installation instructions](https://cert-manager.io/docs/installation/) ##### Changes since `v1.14.0` ##### Bug or Regression - Fix broken cainjector image value in Helm chart ([#6693](cert-manager/cert-manager#6693), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Fix bug in cmctl namespace detection which prevented it being used as a startupapicheck image in namespaces other than cert-manager. ([#6706](cert-manager/cert-manager#6706), [@inteon](https://github.com/inteon)) - Fix bug in cmctl which caused `cmctl experimental install` to panic. ([#6706](cert-manager/cert-manager#6706), [@inteon](https://github.com/inteon)) ### [`v1.14.0`](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.0) [Compare Source](cert-manager/cert-manager@v1.13.3...v1.14.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. > ⚠️ This version has known issues. Please install `v1.14.1` instead. > > During the release of `v1.14.0`, the Helm chart was found to use the wrong OCI image for the `cainjector` Deployment, > which caused the Helm installation and the static manifest based installation to fail. > Upon discovery of this bug, the release of `v1.14.0` was paused before the Helm chart or GitHub release were published; > but the Git tag and the OCI images had already been published. > > The cert-manager team next fixed the Helm chart and two other bugs which are listed in the "Known Issues" section below, > and then released `v1.14.1`, which is the version that users are strongly advised to install when they upgrade to 1.14. > > In order to complete the stalled `v1.14.0` release, > the Helm chart and static YAML installation files were regenerated on a team member's laptop, > using exactly the same build scripts as are used in the automated release process, > and using the `v1.14.1` version of the code. > The working `v1.14.0` Helm chart was published, > and the working versions of the static manifest files attached to the draft `v1.14.0` GitHub release, > and that was then published. > > For these reasons, users are strongly advised to skip this version and install the `v1.14.1` Helm chart instead. ##### Known Issues - During the release of `v1.14.0`, the Helm chart for this version was found to use the wrong OCI image for the `cainjector` Deployment, which caused the Helm installation to fail. In order to complete the release, the cert-manager team have manually updated the Helm chart for this version, which contains all the Helm chart fixes which are in `v1.14.1`. But users are strongly advised to skip this version and install the `v1.14.1` Helm chart instead. - A bug in cmctl namespace detection prevents it being used as a `startupapicheck` image in namespaces other than cert-manager. - A bug in cmctl causes `cmctl experimental install` to panic. ##### Breaking Changes The startupapicheck job uses a new OCI image called "startupapicheck", instead of the ctl image. If you run in an environment in which images cannot be pulled, be sure to include the new image. The KeyUsage and BasicConstraints extensions will now be encoded as critical in the CertificateRequest's CSR blob. ##### Major Themes ##### New X.509 Features The cert-manager Certificate resource now allows you to configure a subset of "Other Name" SANs, which are described in the [Subject Alternative Name section of RFC 5280](https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.6) (on page 37). We specifically support any `otherName` type with a `UTF-8` value, such as the [User Principal Name](https://docs.venafi.com/Docs/current/TopNav/Content/Certificates/r-UEP-support-SANs.php) or [`sAMAccountName`](https://learn.microsoft.com/en-us/windows/win32/ad/naming-properties). These are useful when issuing unique certificates for authenticating with LDAP systems such as Microsoft Active Directory. For example you can create certificates with this block in the spec: otherNames: - oid: 1.3.6.1.4.1.311.20.2.3 # UPN OID utf8Value: upn@domain.local The feature is still in alpha stage and requires you to [enable the `OtherName` feature flag in the controller and webhook components](../../installation/configuring-components.md#feature-gates). ##### New CA certificate Features You can now specify the X.509 v3 Authority Information Accessors extension, with URLs for certificates issued by the CA issuer. Users can now use name constraints in CA certificates. To know more details on name constraints check out RFC section https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.10 ##### Security An ongoing security audit of the cert-manager code revealed some weaknesses which we have addressed in this release, such as using more secure default settings in the HTTP servers that serve metrics, healthz and pprof endpoints. This will help mitigate denial-of-service attacks against those important services. All the cert-manager containers are now configured with read only root file system by default, to prevent unexpected changes to the file system of the OCI image. And it is now possible to configure the metrics server to use HTTPS rather than HTTP, so that clients can verify the identity of the metrics server. ##### Other The liveness probe of the cert-manager controller Pod is now enabled by default. There is a new option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS. ##### Community Thanks again to all open-source contributors with commits in this release, including: - [@ABWassim](https://github.com/ABWassim) - [@JoeNorth](https://github.com/JoeNorth) - [@allenmunC1](https://github.com/allenmunC1) - [@asapekia](https://github.com/asapekia) - [@jeremycampbell](https://github.com/jeremycampbell) - [@jkroepke](https://github.com/jkroepke) - [@jsoref](https://github.com/jsoref) - [@lauraseidler](https://github.com/lauraseidler) - [@pevidex](https://github.com/pevidex) - [@phillebaba](https://github.com/phillebaba) - [@snorwin](https://github.com/snorwin) - [@tanujd11](https://github.com/tanujd11) - [@tberreis](https://github.com/tberreis) - [@vinny](https://github.com/vinny) Thanks also to the following cert-manager maintainers for their contributions during this release: - [@SgtCoDFish](https://github.com/SgtCoDFish) - [@SpectralHiss](https://github.com/SpectralHiss) - [@ThatsMrTalbot](https://github.com/ThatsMrTalbot) - [@hawksight](https://github.com/hawksight) - [@inteon](https://github.com/inteon) - [@maelvls](https://github.com/maelvls) - [@wallrj](https://github.com/wallrj) Equally thanks to everyone who provided feedback, helped users and raised issues on GitHub and Slack and joined our meetings! Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://github.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. ##### Changes ##### Feature - ACME challenge solver Pod for HTTP01 will get a default annotation of `"cluster-autoscaler.kubernetes.io/safe-to-evict": "true"`. You can provide an annotation of `"cluster-autoscaler.kubernetes.io/safe-to-evict": "false"` in your `podTemplate` if you don't like this. ([#6349](cert-manager/cert-manager#6349), [@jsoref](https://github.com/jsoref)) - Added a clock skew detector liveness probe that will force a restart in case we detect a skew between the internal monotonic clock and the system clock of more than 5 minutes. Also, the controller's liveness probe is now enabled by default. ([#6328](cert-manager/cert-manager#6328), [@inteon](https://github.com/inteon)) - Added a new flag (--dynamic-serving-leaf-duration) that can adjust the lifetime of the dynamic leaf certificates ([#6552](cert-manager/cert-manager#6552), [@allenmunC1](https://github.com/allenmunC1)) - Added support for `otherName` SANS in Certificates ([#6404](cert-manager/cert-manager#6404), [@SpectralHiss](https://github.com/SpectralHiss)) - Added the option to specify the X.509 v3 Authority Information Accessors extension CA Issuers URLs for certificates issued by the CA issuer. ([#6486](cert-manager/cert-manager#6486), [@jeremycampbell](https://github.com/jeremycampbell-okta)) - Adds cert-manager's new core infrastructure initiative badge! See more details on https://www.bestpractices.dev/projects/8079 ([#6497](cert-manager/cert-manager#6497), [@SgtCoDFish](https://github.com/SgtCoDFish)) - All Pods are now configured with `readOnlyRootFilesystem` by default. ([#6453](cert-manager/cert-manager#6453), [@wallrj](https://github.com/wallrj)) - MAYBE BREAKING: The startupapicheck job is now handled by an entirely new container called "startupapicheck". This replaces the previous ctl container. If you run in an environment in which images cannot be pulled, be sure to include the new container. ([#6549](cert-manager/cert-manager#6549), [@SgtCoDFish](https://github.com/SgtCoDFish)) - New option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS[#12](cert-manager/cert-manager#12) keystores. Fixes issues [#5957](cert-manager/cert-manager#5957) and [#6523](cert-manager/cert-manager#6523). ([#6548](cert-manager/cert-manager#6548), [@snorwin](https://github.com/snorwin)) - The ACME HTTP01 solver Pod is now configured with `readOnlyRootFilesystem: true` ([#6462](cert-manager/cert-manager#6462), [@wallrj](https://github.com/wallrj)) - Updates the AWS SDK for Go to 1.48.7 to support Amazon EKS Pod Identity ([#6519](cert-manager/cert-manager#6519), [@JoeNorth](https://github.com/JoeNorth)) - Users can now use name constraints in CA certificates. To know more details on name constraints check out RFC section https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.10 ([#6500](cert-manager/cert-manager#6500), [@tanujd11](https://github.com/tanujd11)) - ⚠️ potentially breaking ⚠️: The KeyUsage and BasicConstraints extensions will now be encoded as critical in the CertificateRequest's CSR blob. ([#6053](cert-manager/cert-manager#6053), [@inteon](https://github.com/inteon)) - Add TLS support to the metrics endpoint through either a certificate file or through dynamically issued certificates ([#6574](cert-manager/cert-manager#6574), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Helm Chart: allow changing the default Deployment `revisionHistoryLimit` ([#6248](cert-manager/cert-manager#6248), [@tberreis](https://github.com/tberreis)) - Security: Limit the size of the response body read from HTTP requests by cert-manager. ([#6619](cert-manager/cert-manager#6619), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Support custom `spec.namespaceSelector` for webhooks ([#6638](cert-manager/cert-manager#6638), [@jkroepke](https://github.com/jkroepke)) ##### Bug or Regression - BUGFIX\[helm]: Fix issue where webhook feature gates were only set if controller feature gates are set. ([#6380](cert-manager/cert-manager#6380), [@asapekia](https://github.com/asapekia)) - Controller ConfigMap is now created only if `.Values.config` is set. ([#6357](cert-manager/cert-manager#6357), [@ABWassim](https://github.com/ABWassim)) - Fix runaway bug caused by multiple Certificate resources that point to the same Secret resource. ([#6406](cert-manager/cert-manager#6406), [@inteon](https://github.com/inteon)) - Fix(helm): templating of required value in controller and webhook ConfigMap resources ([#6435](cert-manager/cert-manager#6435), [@ABWassim](https://github.com/ABWassim)) - Fixed a webhook validation error message when the key algorithm was invalid. ([#6571](cert-manager/cert-manager#6571), [@pevidex](https://github.com/pevidex)) - Fixed error messaging when setting up vault issuer ([#6433](cert-manager/cert-manager#6433), [@vinny](https://github.com/vinny-sabatini)) - `GHSA-vgf6-pvf4-34rq`: The webhook server now returns HTTP error 413 (Content Too Large) for requests with body size `>= 3MiB`. This is to mitigate DoS attacks that attempt to crash the webhook process by sending large requests that exceed the available memory. The webhook server now returns HTTP error 400 (Bad Request) if the request contains an empty body. The webhook server now returns HTTP error 500 (Internal Server Error) rather than crashing, if the code panics while handling a request. ([#6498](cert-manager/cert-manager#6498), [@inteon](https://github.com/inteon)) - Increase the default webhook timeout to its maximum value of 30 seconds, so that the underlying timeout error message has more chance of being returned to the end user. ([#6488](cert-manager/cert-manager#6488), [@wallrj](https://github.com/wallrj)) - Listeners that do not support TLS on Gateway resources will now not raise `BadConfig` warnings anymore ([#6347](cert-manager/cert-manager#6347), [@lauraseidler](https://github.com/lauraseidler)) - Mitigate potential Slowloris attacks by setting `ReadHeaderTimeout` in all `http.Server` instances ([#6534](cert-manager/cert-manager#6534), [@wallrj](https://github.com/wallrj)) - The Venafi issuer now properly resets the certificate and should no longer get stuck with `WebSDK CertRequest Module Requested Certificate` or `This certificate cannot be processed while it is in an error state. Fix any errors, and then click Retry.`. ([#6398](cert-manager/cert-manager#6398), [@maelvls](https://github.com/maelvls)) - Update experimental install and uninstall commands to have flag parity with the rest of the CLI ([#6562](cert-manager/cert-manager#6562), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Webhook ConfigMap if now created only if `.Values.webhook.config` is set. ([#6360](cert-manager/cert-manager#6360), [@ABWassim](https://github.com/ABWassim)) - BUGFIX: Ensure `otherName` SAN changes in Certificate resources trigger re-issuance. ([#6620](cert-manager/cert-manager#6620), [@SpectralHiss](https://github.com/SpectralHiss)) - Bugfix: Publish the `startupapicheck` image to `quay.io` ([#6609](cert-manager/cert-manager#6609), [@wallrj](https://github.com/wallrj)) ##### Other (Cleanup or Flake) - Cert-manager is now built with Go 1.21.5 ([#6545](cert-manager/cert-manager#6545), [@wallrj](https://github.com/wallrj)) - Bump Go to `1.21.3` to address `CVE-2023-39325`. Also bumps base images. ([#6410](cert-manager/cert-manager#6410), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Bump `golang.org/x/net v0.15.0 => v0.17.0` as part of addressing `CVE-2023-44487` / `CVE-2023-39325` ([#6427](cert-manager/cert-manager#6427), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Check code for unintended use of `crypto/md5`, a weak cryptographic primitive; using `golangci-lint` / `gosec` (G501). ([#6581](cert-manager/cert-manager#6581), [@wallrj](https://github.com/wallrj)) - Check code for unintended use of `crypto/sha1`, a weak cryptographic primitive; using `golangci-lint` / `gosec` (G505). ([#6579](cert-manager/cert-manager#6579), [@wallrj](https://github.com/wallrj)) - Check code for unintended use of weak random number generator (`math/rand` instead of `crypto/rand`); using `golangci-lint` / `gosec` (G404). ([#6582](cert-manager/cert-manager#6582), [@wallrj](https://github.com/wallrj)) - Cleanup: Restrict MutatingWebhookConfiguration to only CertificateRequest resources ([#6311](cert-manager/cert-manager#6311), [@hawksight](https://github.com/hawksight)) - Deprecated `pkg/util.RandStringRunes` and `pkg/controller/test.RandStringBytes`. Use `k8s.io/apimachinery/pkg/util/rand.String` instead. ([#6585](cert-manager/cert-manager#6585), [@wallrj](https://github.com/wallrj)) - Enabled verbose logging in startupapicheck by default, so that if it fails, users can know exactly what caused the failure. ([#6495](cert-manager/cert-manager#6495), [@wallrj](https://github.com/wallrj)) - Fix gosec G601: Implicit memory aliasing of items from a range statement ([#6551](cert-manager/cert-manager#6551), [@wallrj](https://github.com/wallrj)) - Fix handling of serial numbers in literal certificate subjects. Previously a serial number could be specified in `subject.serialNumber` while using a literal certificate subject. This was a mistake and has been fixed. ([#6533](cert-manager/cert-manager#6533), [@inteon](https://github.com/inteon)) - The end-to-end tests can now test the cert-manager Vault Issuer on an OpenShift cluster. ([#6391](cert-manager/cert-manager#6391), [@wallrj](https://github.com/wallrj)) - Update cert-manager's distroless base images from Debian 11 to Debian 12. This should have no practical effects on users. ([#6583](cert-manager/cert-manager#6583), [@inteon](https://github.com/inteon)) - Updated all code using GatewayAPI to use the now GA v1 APIs ([#6559](cert-manager/cert-manager#6559), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - Upgrade Go from 1.20.7 to 1.20.8. ([#6369](cert-manager/cert-manager#6369), [@inteon](https://github.com/inteon)) - Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE". ([#6366](cert-manager/cert-manager#6366), [@inteon](https://github.com/inteon)) - Use the new generic `sets.Set` type in place of the deprecated `sets.String`. ([#6586](cert-manager/cert-manager#6586), [@wallrj](https://github.com/wallrj)) - cert-manager is now built with Go `v1.21.6` ([#6628](cert-manager/cert-manager#6628), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Update the Azure SDK and remove deprecated `autorest` dependency ([#5452](cert-manager/cert-manager#5452), [@phillebaba](https://github.com/phillebaba)) - The cert-manager E2E tests can now be run on Kubernetes 1.29 ([#6641](cert-manager/cert-manager#6641), [@wallrj](https://github.com/wallrj)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/358 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

inteon · 2024-02-06T09:20:55Z

@ThatsMrTalbot the "github.com/cert-manager/cert-manager/pkg/webhook/authority" package was moved to an internal package. This breaks approver-policy which imports this library (cert-manager/approver-policy#368).
Could you take a look at this problem and propose a solution?

ThatsMrTalbot · 2024-02-06T10:00:46Z

I think there are two real options:

Move the code into its own package, the code is not part of the core cert-manager offering, it just sets up a webserver with optional TLS. This is more effort, but is one less dependency between the two codebases.
Move the package out the internal directory to the pkg directory so it can be consumed by other cert-manager projects. This is less effort and the quickest win.

inteon · 2024-02-06T15:22:09Z

@ThatsMrTalbot
It seems like a long time ago we were actually building a similar library: https://github.com/cert-manager/webhook-lib

feat: add tls to metrics endpoint

ae143c1

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot changed the title ~~WIP feat: add tls to metrics endpoin~~ WIP feat: add tls to metrics endpoint Dec 27, 2023

jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Dec 27, 2023

feat: add example for setting up TLS on metrics endpoint via the helm…

2897f78

… chart Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot force-pushed the tls-metrics-endpoint branch from 5f6b37f to 2897f78 Compare January 2, 2024 13:38

feat: add validation for metrics tls config

eb5033c

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot changed the title ~~WIP feat: add tls to metrics endpoint~~ feat: add tls to metrics endpoint Jan 2, 2024

jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2024

wallrj self-requested a review January 4, 2024 13:53

jetstack-bot added this to the 1.14 milestone Jan 4, 2024

jetstack-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 4, 2024

wallrj requested changes Jan 4, 2024

View reviewed changes

refactor: refactored metrics server code into internal package

d27fcc2

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

ThatsMrTalbot force-pushed the tls-metrics-endpoint branch from 87635f3 to d27fcc2 Compare January 4, 2024 15:49

wallrj requested changes Jan 8, 2024

View reviewed changes

wallrj mentioned this pull request Jan 10, 2024

Add TLS support for /metrics prometheus server #6558

Closed

fix: correct log line now tls is not just for webhook

0175ab3

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>

wallrj approved these changes Jan 10, 2024

View reviewed changes

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024

jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024

jetstack-bot merged commit a1c134e into cert-manager:master Jan 10, 2024
7 checks passed

ThatsMrTalbot mentioned this pull request Jan 16, 2024

Project Admin for @ThatsMrTalbot cert-manager/community#19

Closed

wallrj mentioned this pull request Feb 1, 2024

Add more cross reference links to the Security items in the release notes cert-manager/website#1410

Merged

wallrj mentioned this pull request Feb 14, 2024

Release cert manager 1.14 cert-manager/cert-manager-olm#105

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add tls to metrics endpoint #6574

feat: add tls to metrics endpoint #6574

ThatsMrTalbot commented Dec 27, 2023 •

edited

ThatsMrTalbot commented Jan 2, 2024

ThatsMrTalbot commented Jan 2, 2024

ThatsMrTalbot commented Jan 2, 2024

wallrj commented Jan 4, 2024

wallrj left a comment

wallrj commented Jan 4, 2024

ThatsMrTalbot commented Jan 4, 2024

wallrj left a comment

wallrj Jan 8, 2024

ThatsMrTalbot Jan 10, 2024

wallrj commented Jan 10, 2024

wallrj left a comment

jetstack-bot commented Jan 10, 2024

inteon commented Feb 6, 2024

ThatsMrTalbot commented Feb 6, 2024

inteon commented Feb 6, 2024

feat: add tls to metrics endpoint #6574

feat: add tls to metrics endpoint #6574

Conversation

ThatsMrTalbot commented Dec 27, 2023 • edited

Pull Request Motivation

Kind

Release Note

ThatsMrTalbot commented Jan 2, 2024

ThatsMrTalbot commented Jan 2, 2024

ThatsMrTalbot commented Jan 2, 2024

wallrj commented Jan 4, 2024

wallrj left a comment

Choose a reason for hiding this comment

wallrj commented Jan 4, 2024

ThatsMrTalbot commented Jan 4, 2024

wallrj left a comment

Choose a reason for hiding this comment

wallrj Jan 8, 2024

Choose a reason for hiding this comment

ThatsMrTalbot Jan 10, 2024

Choose a reason for hiding this comment

wallrj commented Jan 10, 2024

wallrj left a comment

Choose a reason for hiding this comment

jetstack-bot commented Jan 10, 2024

inteon commented Feb 6, 2024

ThatsMrTalbot commented Feb 6, 2024

inteon commented Feb 6, 2024

ThatsMrTalbot commented Dec 27, 2023 •

edited