Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rclone gcs bucket ACL #6906

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

inteon
Copy link
Member

@inteon inteon commented Apr 15, 2024

fixes cert-manager/infrastructure#33

@maelvls discovered that rclone does not work with GCS buckets that have "uniform bucket level access" enabled instead of ACL (see cert-manager/infrastructure#33).
This PR aims to change our rclone command so it works with "uniform bucket level access" GCS buckets.
I'll also backport this PR to 1.14, 1.13 and 1.12.

Kind

/kind cleanup

Release Note

NONE

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2024
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Makes sense to me that we'd want to move away from ACLs!

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2024
@SgtCoDFish
Copy link
Member

/test pull-cert-manager-master-e2e-v1-28

@inteon inteon merged commit 4e0854a into cert-manager:master Apr 22, 2024
6 checks passed
@inteon
Copy link
Member Author

inteon commented Apr 22, 2024

/cherrypick release-1.14

@cert-manager-bot
Copy link
Contributor

@inteon: #6906 failed to apply on top of branch "release-1.14":

Applying: disable rclone gcs bucket ACL
Using index info to reconstruct a base tree...
M	make/release.mk
Falling back to patching base and 3-way merge...
Auto-merging make/release.mk
CONFLICT (content): Merge conflict in make/release.mk
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable rclone gcs bucket ACL
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants