-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rclone gcs bucket ACL #6906
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Makes sense to me that we'd want to move away from ACLs!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cert-manager-master-e2e-v1-28 |
/cherrypick release-1.14 |
@inteon: #6906 failed to apply on top of branch "release-1.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes cert-manager/infrastructure#33
@maelvls discovered that rclone does not work with GCS buckets that have "uniform bucket level access" enabled instead of ACL (see cert-manager/infrastructure#33).
This PR aims to change our rclone command so it works with "uniform bucket level access" GCS buckets.
I'll also backport this PR to 1.14, 1.13 and 1.12.
Kind
/kind cleanup
Release Note