Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart: remove endpoints from rbac resources #769

Merged
merged 3 commits into from
Jul 27, 2018
Merged

helm chart: remove endpoints from rbac resources #769

merged 3 commits into from
Jul 27, 2018

Conversation

jstriebel
Copy link
Contributor

@jstriebel jstriebel commented Jul 26, 2018 •
edited

As version 0.4 is used now, it should be safe to remove endpoints from the ClusterRole resources. See old TODO in code.

Release Note

NONE

@jetstack-bot jetstack-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 26, 2018
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2018
@jstriebel jstriebel mentioned this pull request Jul 26, 2018
Closed
@munnerz
Copy link
Member

munnerz commented Jul 26, 2018

/ok-to-test

@jetstack-bot jetstack-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 26, 2018
@munnerz
Copy link
Member

munnerz commented Jul 26, 2018

You'll need to bump the helm chart version as part of this PR, as well as running ./hack/update-deploy-gen.sh to regenerate the static manifests 😄

@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2018
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 26, 2018
@jstriebel
Copy link
Contributor Author

@munnerz I updated this accordingly. Anything else missing?

@munnerz
Copy link
Member

munnerz commented Jul 27, 2018

Thanks! 😄

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2018
@jetstack-bot jetstack-bot merged commit e2226b8 into cert-manager:master Jul 27, 2018
@jstriebel jstriebel deleted the patch-1 branch July 27, 2018 09:46
@jstriebel jstriebel mentioned this pull request Jul 27, 2018
Closed
@munnerz munnerz mentioned this pull request Sep 10, 2018
Merged
munnerz added a commit to munnerz/charts-1 that referenced this pull request Sep 10, 2018
@munnerz
cert-manager: fast-forward to upstream bcffc635
e058fde 
* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>
k8s-ci-robot pushed a commit to helm/charts that referenced this pull request Sep 13, 2018
@munnerz @k8s-ci-robot
cert-manager: fast-forward to upstream 3945595b (#7644)
e0505bb 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
@munnerz @jicowan
cert-manager: fast-forward to upstream 3945595b (helm#7644)
2b1a940 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@munnerz @Jnig
cert-manager: fast-forward to upstream 3945595b (helm#7644)
42fb445 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@munnerz @wgiddens
cert-manager: fast-forward to upstream 3945595b (helm#7644)
1100fa3 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jstriebel @munnerz @jetstack-bot