chart: annotate all CRDs with "crd-install" hook #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccojocar: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
do-not-merge/release-note-label-needed
ccojocar
force-pushed
the
chart-crd-hook
branch
from
15961b4
to
82e114d
Compare
|
/ok-to-test |
jetstack-bot
added
size/S
ccojocar
force-pushed
the
chart-crd-hook
branch
from
5f80a98
to
5b10f56
Compare
jetstack-bot
added
size/M
This fix is required in order to make helm properly verify the CRDs when cert-manager chart is referenced as a dependency of another chart. Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
ccojocar
force-pushed
the
chart-crd-hook
branch
from
d612439
to
d2d1780
Compare
|
@munnerz It seems that the e2e tests fail without being related to my changes. Please could you help with the build? Thanks |
|
It looks to me like Helm is failing to install the CRDs properly on versions of Helm that do not support this hook (i.e. pre-2.10). We currently do not use Helm 2.10 as part of our CI infrastructure, hence the errors. We'll be upgrading as soon as 2.10 stable comes out, but in the meantime this sort of thing is effectively blocked, as it'll mean using the Helm chart will require users have a RC version of Helm/Tiller installed in their cluster 😬 |
|
@munnerz Thanks for help! Let me see if I can make it backward compatible. |
Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
ccojocar
force-pushed
the
chart-crd-hook
branch
from
db7be5b
to
d80f8a9
Compare
|
@munnerz The annotation is now applied only for helm 2.10 |
|
Thanks @ccojocar! /lgtm |
|
/release-note-none |
jetstack-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
|
@munnerz now that |
munnerz
added a commit
to munnerz/charts-1
that referenced
this pull request
Sep 10, 2018
* Update version numbers for v0.5.0 (cert-manager/cert-manager#885) * added affinity and tolerations (cert-manager/cert-manager#869) * Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478) * chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823) * helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769) Signed-off-by: James Munnelly <james@munnelly.eu>
k8s-ci-robot
pushed a commit
to helm/charts
that referenced
this pull request
Sep 13, 2018
* cert-manager: fast-forward to upstream bcffc635 * Update version numbers for v0.5.0 (cert-manager/cert-manager#885) * added affinity and tolerations (cert-manager/cert-manager#869) * Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478) * chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823) * helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769) Signed-off-by: James Munnelly <james@munnelly.eu> * Update image tag and add description Signed-off-by: James Munnelly <james@munnelly.eu>
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
* cert-manager: fast-forward to upstream bcffc635 * Update version numbers for v0.5.0 (cert-manager/cert-manager#885) * added affinity and tolerations (cert-manager/cert-manager#869) * Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478) * chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823) * helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769) Signed-off-by: James Munnelly <james@munnelly.eu> * Update image tag and add description Signed-off-by: James Munnelly <james@munnelly.eu> Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* cert-manager: fast-forward to upstream bcffc635 * Update version numbers for v0.5.0 (cert-manager/cert-manager#885) * added affinity and tolerations (cert-manager/cert-manager#869) * Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478) * chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823) * helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769) Signed-off-by: James Munnelly <james@munnelly.eu> * Update image tag and add description Signed-off-by: James Munnelly <james@munnelly.eu> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* cert-manager: fast-forward to upstream bcffc635 * Update version numbers for v0.5.0 (cert-manager/cert-manager#885) * added affinity and tolerations (cert-manager/cert-manager#869) * Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478) * chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823) * helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769) Signed-off-by: James Munnelly <james@munnelly.eu> * Update image tag and add description Signed-off-by: James Munnelly <james@munnelly.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It annotates all CRDs with "crd-install" hook.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #This fix is required in order to make helm properly verify the CRDs
when cert-manager chart is referenced as a dependency of another chart.
Special notes for your reviewer:
@munnerz Do I have to send this patch also to
stable/cert-managerchart, or are you going to sync that chart from this repo?Release note: