New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding aws testing infra #1
Conversation
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
@jakexks here's the complete error message:
|
aws/main.tf
Outdated
|
||
provider "helm" { | ||
kubernetes { | ||
config_path = "${path.module}/kubeconfig_cert-manager-cluster" ## check this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did use ${path.module}
here but even then it fails midway saying the file doesn't exist but when I run terraform apply
again then it works.
aws/main.tf
Outdated
kubernetes { | ||
config_path = "${path.module}/kubeconfig_cert-manager-cluster" ## check this | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes { | |
config_path = "${path.module}/kubeconfig_cert-manager-cluster" ## check this | |
} | |
kubernetes { | |
host = data.aws_eks_cluster.cluster.endpoint | |
cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data) | |
exec { | |
api_version = "client.authentication.k8s.io/v1alpha1" | |
args = ["eks", "get-token", "--cluster-name", module.eks.cluster_id] | |
command = "aws" | |
} | |
} | |
Terraform can construct a dependency graph if you directly reference other terraform resources. The reason you're getting an error some of the time is you're referencing a direct path to a config file that may or may not be there at the time terraform evaluates it
Thanks for reviewing @jakexks! I added the changes you suggested but I'm still not able to figure out how to get out of the current state I'm stuck in. After these changes When I run
And if I run
Is there a way to reset everything and start from scratch with these new changes? 馃槄 |
Update: So I deleted all the files terraform generates and just let the |
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
@jakexks I forgot that you had mentioned that we don't even need the load balancer hostname as output now since we use the route 53 zone. This means the error during |
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakexks, RinkiyaKeDad The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: RinkiyaKeDad arshsharma461@gmail.com
Making a WIP PR so that reviewing errors is easier 馃檪