Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip shipping cmctl for v1.15.0-alpha.0 and above #169

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented Mar 29, 2024

We removed cmctl from the ./cmd/ctl in the main repository and moved it in the repository https://github.com/cert-manager/cmctl.

I propose to add some logic that will skip the binaries for ./cmd/ctl.

I'm not sure how this will play out for the startupapicheck container used in the Helm chart since the Helm chart currently uses a single version for all containers. We need to figure this out before this PR is merged! All is well since the startupapicheck binary still belongs to the cert-manager project and will still be pushed.

Manual testing while releasing 1.15.0-alpha.0

First, I had to point to my branch (rg = ripgrep):

rg _RELEASE_REPO_REF --files-with-matches \
  | xargs perl -pi -e 's/_RELEASE_REPO_REF:.*/_RELEASE_REPO_REF: "skip-cmctl-older-versions"/g'

Then:

go run ./cmd/cmrel publish --release-name v1.15.0-alpha.0

It passed: https://console.cloud.google.com/cloud-build/builds;region=global/a34b853b-bfe7-4af6-b649-d9a14af851da;tab=detail?project=cert-manager-release

Then, I tested --nomock:

go run ./cmd/cmrel publish --release-name v1.15.0-alpha.0 --nomock

It also passed: https://console.cloud.google.com/cloud-build/builds/afd44d68-cc93-470c-ac2b-e862b6071017?project=1021342095237

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 29, 2024
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I think this might be the last piece in the "move cmctl to a different repo" puzzle.
Thank you for making this work!
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@jetstack-bot jetstack-bot merged commit 22db65f into master Apr 2, 2024
3 checks passed
@maelvls maelvls deleted the skip-cmctl-older-versions branch April 2, 2024 14:02
SgtCoDFish added a commit that referenced this pull request Apr 24, 2024
This bug was introduced in #169

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
SgtCoDFish added a commit that referenced this pull request Apr 24, 2024
This bug was introduced in #169

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants