Skip shipping cmctl for v1.15.0-alpha.0 and above #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed cmctl from the
./cmd/ctl
in the main repository and moved it in the repository https://github.com/cert-manager/cmctl.I propose to add some logic that will skip the binaries for
./cmd/ctl
.I'm not sure how this will play out for theAll is well since the startupapicheck binary still belongs to the cert-manager project and will still be pushed.startupapicheck
container used in the Helm chart since the Helm chart currently uses a single version for all containers. We need to figure this out before this PR is merged!Manual testing while releasing 1.15.0-alpha.0
First, I had to point to my branch (rg = ripgrep):
Then:
It passed: https://console.cloud.google.com/cloud-build/builds;region=global/a34b853b-bfe7-4af6-b649-d9a14af851da;tab=detail?project=cert-manager-release
Then, I tested
--nomock
:It also passed: https://console.cloud.google.com/cloud-build/builds/afd44d68-cc93-470c-ac2b-e862b6071017?project=1021342095237