Sort versions when running "cmrel staged" and add cmrel staged --help #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
wallrj
requested changes
Jun 1, 2021
wallrj
reviewed
Jun 1, 2021
maelvls
force-pushed
the
sort-staged
branch
2 times, most recently
from
d538ce9
to
93bdf4c
Compare
jetstack-bot
added
the
needs-rebase
Signed-off-by: Ma毛l Valais <mael@vls.dev>
Signed-off-by: Ma毛l Valais <mael@vls.dev> Co-authored-by: Richard Wall <richard.wall@jetstack.io>
jetstack-bot
removed
the
needs-rebase
This column was always set to 'UNKNOWN', and I was not able to find where the creation timestamp of a given folder in the bucket is, so removing this column makes sense. Signed-off-by: Ma毛l Valais <mael@vls.dev>
wallrj
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Looks good @maelvls
I tested it by doing a full listing and a specific version listing.
Both worked.
I noticed a few unrelated problems with it, all of which we can fix in future PRs:
- The version is printed to stderr rather stdout
- There's no way to print only the version, or release-name
- The CLI --help description talks about a
--release-nameoption, but I don't see that listed in:
$ go run ./cmd/cmrel staged --help
...
Flags:
--bucket string The name of the GCS bucket containing the staged releases. (default "cert-manager-release")
--git-ref string Optional specific git reference to list staged releases for - if specified, --release-version must also be specified.
-h, --help help for staged
--release-type string The type of release to list, usually one of 'release' or 'devel' (default "release")
--release-version string Optional release version override used to force the version strings used during the release to a specific value.
Global Flags:
--debug If true, output from sub-commands will be directly piped to stderr.
| @@ -12,6 +12,7 @@ require ( | |||
| github.com/spf13/cobra v1.1.3 | |||
| github.com/spf13/pflag v1.0.5 | |||
| github.com/stretchr/testify v1.6.1 | |||
| golang.org/x/mod v0.4.1 // indirect | |||
There was a problem hiding this comment.
We should add a verify-go-mod script because this isn't indirect any more and go mod tidy fixes that.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
stagedwas quite confusing since the versions would show in some random order. It now sorts versions lexicographically which means that the bottom lines are the latest tags.Before:
After:
The
--helphad been copied from thestagecommand, so it was not really helpful. I tried to improve the help a little 馃槄Before:
After: