-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to write generated prow config, and automatically create pull request against jetstack/testing #89
Option to write generated prow config, and automatically create pull request against jetstack/testing #89
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you confirm that we want to update the prow definitions for all branches? |
Yep, I hear you on not changing those tests. Ideally we should be codifying that these tests don't change using the release program (which is what this PR achieves). If we do want to update the tests in future (for example if we want to delete them and add a new branch), this PR will do that too. |
2c0bdcc
to
f2ff91f
Compare
Added a workflow to show what the changes are going to be made on the jetstack/testing repo https://github.com/cert-manager/release/runs/7802831243?check_suite_focus=true |
files. Signed-off-by: joshvanl <me@joshvanl.dev>
jetstack/testing when the cert-manager prow config changes Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
f2ff91f
to
0fdfaa9
Compare
Please see https://github.com/cert-manager/release/runs/7875736927?check_suite_focus=true which shows that only master branch prow jobs have updated images. |
@JoshVanL thank you for fixing this. |
Yes, the value of the image itself is not to do with this PR. Will follow up with a separate PR that fixes that. |
/lgtm |
This PR adds a new flag
--output
togenerate-prow
. The defaultstdout
value prints to stdout as it does currently.file
will write the prow config to a directory and file in form<branch>/cert-manager-<branch>.yaml
to mimic the existing path structure.The
branches
flag now also accepts a value of*
which will loop over all existing known branches.A github workflow is added which (hopefully) runs the generate command when a
cert-manager/release
PR is merged. If the output is different to what is currently injetstack/testing
, then a PR will be opened with the changes.This new workflow uses
peter-evans/create-pull-request@v4
. I don't know how we using a third party action like this.An informational verify
verify / show-prow-config-changes
workflow is added which will show the diff to thejetstack/testing
repo.