Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run terraform linter in CI #27

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

lonelyCZ
Copy link
Contributor

Signed-off-by: lonelyCZ 531187475@qq.com

Fixes #3

@lonelyCZ
Copy link
Contributor Author

/assign @irbekrm

Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonelyCZ this looks good, I haven't tested it, but read through the workflow and added a couple nits. Happy to merge otherwise, we can then trigger it manually if you add the workflow_dispatch event I think.

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
Signed-off-by: lonelyCZ <531187475@qq.com>
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lonelyCZ this is great work!

/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 219ce06 into cert-manager:master Jul 26, 2022
@irbekrm
Copy link
Contributor

irbekrm commented Jul 26, 2022

I manually triggered the workflow and it ran and passed https://github.com/cert-manager/testing-addons/runs/7516270636?check_suite_focus=true 🥳

@lonelyCZ lonelyCZ deleted the pr-lint-ci branch July 26, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run test (linter) in CI
3 participants