-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run terraform linter in CI #27
Conversation
/assign @irbekrm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lonelyCZ this looks good, I haven't tested it, but read through the workflow and added a couple nits. Happy to merge otherwise, we can then trigger it manually if you add the workflow_dispatch
event I think.
Signed-off-by: lonelyCZ <531187475@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lonelyCZ this is great work!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, lonelyCZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I manually triggered the workflow and it ran and passed https://github.com/cert-manager/testing-addons/runs/7516270636?check_suite_focus=true 🥳 |
Signed-off-by: lonelyCZ 531187475@qq.com
Fixes #3