-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor restructure for ko compatibility #124
Conversation
Move cmd/main.go to cmd/trust-manager/main.go so that `ko` correctly builds as a `trust-manager` binary. This brings it into line with other go project structures. This is a noop as far as the current build mechanism is concerned - it should generate the same thing in the same way, but this restructure facilitates an easier development/test cycle. Signed-off-by: Adrian Lai <adrian.lai@jetstack.io>
Hi @aidy. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Even without thinking about ko
I prefer this structure. Thanks very much!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aidy, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move cmd/main.go to cmd/trust-manager/main.go so that
ko
correctly builds as atrust-manager
binary. This brings it into line with other go project structures.This is a noop as far as the current build mechanism is concerned - it should generate the same thing in the same way, but this restructure facilitates an easier development/test cycle.