Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two new variables to the Helm chart #232

Closed
wants to merge 1 commit into from
Closed

Add two new variables to the Helm chart #232

wants to merge 1 commit into from

Conversation

bodgit
Copy link

@bodgit bodgit commented Nov 14, 2023

  • Allow customising the revisionHistoryLimit field in the Deployment, defaulting to the Kubernetes default of 10.
  • Allow customising the volume used for storing the default trust package, defaulting to the original emptyDir: {} value.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Nov 14, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2023
@jetstack-bot
Copy link
Contributor

Hi @bodgit. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2023
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 14, 2023
inteon
inteon reviewed Nov 21, 2023
View reviewed changes
deploy/charts/trust-manager/templates/deployment.yaml
@@ -120,7 +121,7 @@ spec:
{{- end }}
volumes:
- name: packages
emptyDir: {}
{{- toYaml .Values.packagesVolume | nindent 8 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give an example of how and why you would change this value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from changing the volume type entirely, I can set a sizeLimit parameter on the emptyDir volume, (my primary motivation), or you could use the medium parameter to put it on tmpfs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just seen this PR - I think we'll go in a different direction with this by setting a size limit unilaterally in #308 - appreciate your involvement. If you wanted to reword this to only focus on revisionHistoryLimit (along with maybe some justification for why we should change that) we'd be happy to take a look!

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2024
@jetstack-bot jetstack-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2024
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2024
@bodgit
Add two new variables to the Helm chart
7783b1f 
* Allow customising the `revisionHistoryLimit` field in the Deployment,
  defaulting to the Kubernetes default of 10.
* Allow customising the volume used for storing the default trust
  package, defaulting to the original `emptyDir: {}` value.

Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2024
@bodgit
Copy link
Author

bodgit commented Jan 23, 2024

@inteon did you have any further feedback?

@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2024
@SgtCoDFish
Copy link
Member

Gonna close this since we went a different way with it! Thanks so much @bodgit for raising something - appreciate you getting involved even if we didn't merge this ❤️

@SgtCoDFish SgtCoDFish closed this Mar 5, 2024
@bodgit
Copy link
Author

bodgit commented Mar 5, 2024

Gonna close this since we went a different way with it! Thanks so much @bodgit for raising something - appreciate you getting involved even if we didn't merge this ❤️

I will redo the PR for just the revisionHistoryLimit settings.

@SgtCoDFish
Copy link
Member

Ah sorry - I missed that part entirely!

Yeah if you raise a PR I'll take a look at that. Please feel free to assign it to me and ping me for a review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish left review comments

@inteon inteon inteon left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bodgit @jetstack-bot @SgtCoDFish @inteon