BREAKING: chore: align BundleCondition with upstream metav1.Condition

[erikgb]

This is a PR that replaces #240. Since we decided to not migrate to the upstream metav1.Condition, I have tried to align our own BundleCondition as much as possible the the current upstream struct. Personally, I think it's an improvement that first and foremost will add more API spec validations better protecting us from controller bugs. This is technically breaking changes, but since the trust-manager controller should be the only actor modifying Bundle status, I think it's fine.

Also removing the obsolete validation in the webhook for duplicate conditions. This was code is not needed after #173.

[SgtCoDFish]

/lgtm
/approve
/hold

This looks like an improvement to me. A lot of these changes are technically breaking if we nitpick, but I suspect that it'd be worthwhile to make the changes anyway - I don't feel like we need to wait for v1alpha2 or v1beta1 for these changes.

The hold is either for us to change this PR to be non-breaking (which I absolutely don't expect us to do) or to add an indidator to the PR description that it might be breaking (and thus would be worth mentioning in release notes)

[SgtCoDFish]

/lgtm
/approve

Thanks for this 😁 Took a bit of discussion to get here but I think this is a worthwhile improvement!

[erikgb]

/test pull-trust-manager-verify

[SgtCoDFish]

/lgtm
/approve
/unhold

Thanks!

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment