Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.9] Allow replicaCount to be set to int or string #324

Conversation

SgtCoDFish
Copy link
Member

Cherry pick of #320 into release-0.9 branch.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
@SgtCoDFish
Copy link
Member Author

#325 will fix CI!

@inteon
Copy link
Member

inteon commented Mar 13, 2024

/retest

@erikgb
Copy link
Contributor

erikgb commented Mar 13, 2024

/lgtm
/approve

Thanks! 🎉

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@jetstack-bot jetstack-bot merged commit 6455055 into cert-manager:release-0.9 Mar 13, 2024
4 checks passed
@SgtCoDFish SgtCoDFish deleted the release-0.9-fix-helm-replicas branch March 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants