Allow replicaCount to be set to int or string

[erikgb]

This fix is more or less a copy of cert-manager/approver-policy#388 fixing the same issue here. We are using FluxCD post-build substitutions to override replicas in our single-node review clusters. This used to work fine but broke with version 0.9.0 of trust-manager. Many thanks to @wallrj for finding an acceptable solution to this.

$ helm template deploy/charts/trust-manager/ --set replicaCount='${REPLICAS_OVERRIDE:=3}' | grep replicas
  replicas: ${REPLICAS_OVERRIDE:=3}

$ helm template deploy/charts/trust-manager/ --set replicaCount=2 | grep replicas
  replicas: 2

/cc @SgtCoDFish @wallrj @inteon

[erikgb]

/test pull-trust-manager-smoke

[erikgb]

Somehow CI seems broken`somehow: 🤔

ERROR: failed to solve: process "/bin/sh -c GOPROXY=$GOPROXY go get github.com/cert-manager/trust-manager/cmd/validate-trust-package && GOPROXY=$GOPROXY CGO_ENABLED=0 GOARCH=$TARGETARCH go build -o /go/bin/validate-trust-package github.com/cert-manager/trust-manager/cmd/validate-trust-package" did not complete successfully: exit code: 1
make: *** [make/trust-package-debian.mk:40: trust-package-debian-load] Error 1

[inteon]

/retest

[SgtCoDFish]

Somehow CI seems broken`somehow: 🤔

It's the move to go 1.22, a change in the go toolchain. I'll fix it!

[SgtCoDFish]

/test pull-trust-manager-smoke

[inteon]

@erikgb can you bump the builder go image here? https://github.com/cert-manager/trust-manager/blob/main/trust-packages/debian/Containerfile#L15

/cc @SgtCoDFish

[SgtCoDFish]

#321 should fix!

[inteon]

/retest

[SgtCoDFish]

/lgtm
/approve

Sorry this wasn't a faster process!

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[erikgb]

NP, Ash! Thanks for the review! Looking forward to the patch release including this.