Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enabled from securityContext #1050

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

schwichti
Copy link
Contributor

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.securityContext): unknown field "enabled" in io.k8s.api.core.v1.PodSecurityContext

│ with helm_release.cert_manager,
│ on certmanager.tf line 1, in resource "helm_release" "cert_manager":
│ 1: resource "helm_release" "cert_manager" {

Signed-off-by: Simon Schwichtenberg 33393719+schwichti@users.noreply.github.com

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.securityContext): unknown field "enabled" in io.k8s.api.core.v1.PodSecurityContext
│
│   with helm_release.cert_manager,
│   on certmanager.tf line 1, in resource "helm_release" "cert_manager":
│    1: resource "helm_release" "cert_manager" {

Signed-off-by: Simon Schwichtenberg <33393719+schwichti@users.noreply.github.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 2, 2022
@jetstack-bot
Copy link
Contributor

Hi @schwichti. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2022
@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 747fbe5
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/62e91de4a4e642000a505bb8
😎 Deploy Preview https://deploy-preview-1050--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

Would it be possible for you to also remove this under content/docs and content/next-docs? Those are the docs versions that people are most likely to see on cert-manager.io!

Signed-off-by: Simon Schwichtenberg <33393719+schwichti@users.noreply.github.com>
Signed-off-by: Simon Schwichtenberg <33393719+schwichti@users.noreply.github.com>
@schwichti
Copy link
Contributor Author

Would it be possible for you to also remove this under content/docs and content/next-docs?

done

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/ok-to-test

Brilliant, thank you so much 🎉

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schwichti, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@jetstack-bot jetstack-bot merged commit aae525b into cert-manager:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants