Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation menu hiding search results #1084

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

code-reaper08
Copy link
Contributor

@code-reaper08 code-reaper08 commented Oct 1, 2022

Fixes #1082

Signed-off-by: Vishwa R v.i.s.h.w.a.08.11.2001@gmail.com

Signed-off-by: Vishwa R <v.i.s.h.w.a.08.11.2001@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2022
@jetstack-bot
Copy link
Contributor

Hi @code-reaper08. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2022
@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 91da8e3
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6337fd4b131d760009e1bc44
😎 Deploy Preview https://deploy-preview-1084--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@code-reaper08
Copy link
Contributor Author

/assign @meyskens

@code-reaper08
Copy link
Contributor Author

Hello @meyskens 😄
This PR hopes to fix the issue #1082

Tested the same on devtools too!

@code-reaper08
Copy link
Contributor Author

Hello @meyskens 👋
Just thought to remind you on this PR here.
Will help a lot for me, if you have a look.

Thanks!

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @code-reaper08 and apologies for the delayed reply.

I visited cert-manager.io on a Samsung phone and recreated the problem and then visited the netlify PR preview site and observed that the search menu is now fully visible.

@relativelyrehan This seems like a simpler solution than #1102 but thank you both for helping to fix this problem.

/ok-to-test
/approve
/lgtm

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: code-reaper08, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@jetstack-bot jetstack-bot merged commit 4285d9c into cert-manager:master Jan 12, 2023
@relativelyrehan
Copy link
Contributor

@wallrj @code-reaper08 you're welcome. I just want to point out one little thing. My PR along with solving UI issues also helps with the UX issue as in my solution I made the menu alert to outside clicks such that the menu closed not only on tapping at hamburger but with tapping outside the container too. Nonetheless, happy to help 😊

@wallrj
Copy link
Member

wallrj commented Jan 12, 2023

@wallrj @code-reaper08 you're welcome. I just want to point out one little thing. My PR along with solving UI issues also helps with the UX issue as in my solution I made the menu alert to outside clicks such that the menu closed not only on tapping at hamburger but with tapping outside the container too. Nonetheless, happy to help blush

Ah, I didn't appreciate that. I only clicked on the Algolia "cancel" button when I was testing.

@code-reaper08
Copy link
Contributor Author

@wallrj @code-reaper08 you're welcome. I just want to point out one little thing. My PR along with solving UI issues also helps with the UX issue as in my solution I made the menu alert to outside clicks such that the menu closed not only on tapping at hamburger but with tapping outside the container too. Nonetheless, happy to help 😊

That was really a nice observation @relativelyrehan 🤝💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation menu hiding search results on mobile devices
5 participants