-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: navigation menu hiding search results #1084
Conversation
Signed-off-by: Vishwa R <v.i.s.h.w.a.08.11.2001@gmail.com>
Hi @code-reaper08. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/assign @meyskens |
Hello @meyskens 👋 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @code-reaper08 and apologies for the delayed reply.
I visited cert-manager.io on a Samsung phone and recreated the problem and then visited the netlify PR preview site and observed that the search menu is now fully visible.
@relativelyrehan This seems like a simpler solution than #1102 but thank you both for helping to fix this problem.
/ok-to-test
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: code-reaper08, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wallrj @code-reaper08 you're welcome. I just want to point out one little thing. My PR along with solving UI issues also helps with the UX issue as in my solution I made the menu alert to outside clicks such that the menu closed not only on tapping at hamburger but with tapping outside the container too. Nonetheless, happy to help 😊 |
Ah, I didn't appreciate that. I only clicked on the Algolia "cancel" button when I was testing. |
That was really a nice observation @relativelyrehan 🤝💥 |
Fixes #1082
Signed-off-by: Vishwa R v.i.s.h.w.a.08.11.2001@gmail.com