Release Process: cmctl no longer shipped as part of cert-manager releases #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maelvls
force-pushed
the
update-release-process-again
branch
from
dfe5994
to
0785d8a
Compare
jetstack-bot
added
size/S
maelvls
force-pushed
the
update-release-process-again
branch
from
0785d8a
to
ba6745c
Compare
Cmctl now lives in its own repository. Signed-off-by: Maël Valais <mael@vls.dev>
maelvls
force-pushed
the
update-release-process-again
branch
from
ba6745c
to
fbb18b8
Compare
inteon
reviewed
Apr 2, 2024
| @@ -472,7 +471,7 @@ page if a step is missing or if it is outdated. | |||
|
|
|||
| ```bash | |||
| # Must be run from the cert-manager folder. | |||
| export GITHUB_TOKEN=*your-token* | |||
| export GITHUB_TOKEN=$(gh auth token) | |||
There was a problem hiding this comment.
Wow, haven't tried this yet, but might just be the amazing timesaver I was looking for.
I have always done this through the UI, which takes a lot of time IMO.
inteon
reviewed
Apr 2, 2024
| @@ -385,7 +385,7 @@ page if a step is missing or if it is outdated. | |||
| > kicking off a build using the steps in `gcb/build_cert_manager.yaml`. Users with access to | |||
| > the cert-manager-release project on GCP should be able to view logs in [GCB build history](https://console.cloud.google.com/cloud-build/builds?project=cert-manager-release). | |||
|
|
|||
| 9. **(1.12 and above)** In this step, we make sure the Go module | |||
| 9. **(1.12, 1.13, and 1.14)** In this step, we make sure the Go module | |||
There was a problem hiding this comment.
Is there maybe a way to collapse this item, so it becomes harder to run these steps by accident?
There was a problem hiding this comment.
I implemented this in d83ebca PTAL.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
jetstack-bot
added
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While releasing 1.15.0-alpha.0, I found a couple of inconsistencies due to the fact that
cmctlnow lives in its own repository.