Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple ingresses usage section #446

Merged
merged 1 commit into from Sep 5, 2023
Merged

Add multiple ingresses usage section #446

merged 1 commit into from Sep 5, 2023

Conversation

flmmartins
Copy link

Signed-off-by: Fernanda Martins flmmartins@gmail.com

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2021
@jetstack-bot
Copy link
Contributor

Hi @flmmartins. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2021
@flmmartins flmmartins mentioned this pull request Feb 18, 2021
Closed
@flmmartins
Copy link
Author

Originated from issues:
#cert-manager/cert-manager#841
#cert-manager/cert-manager#2271

@flmmartins
Copy link
Author

assign @munnerz

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021
maelvls
maelvls requested changes Sep 9, 2021
View reviewed changes
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Here is one tiny suggestion.

content/en/docs/usage/ingress.md Outdated Show resolved Hide resolved
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2022
@inteon inteon self-assigned this Sep 5, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit aef6742
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64f6e9f1f4f5700008d54275
😎 Deploy Preview https://deploy-preview-446--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon
Add multiple ingresses usage section
aef6742 
Signed-off-by: Fernanda Martins <flmmartins@gmail.com>
@maelvls
Copy link
Member

maelvls commented Sep 5, 2023

Thanks for updating the PR, Tim!

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@maelvls
Copy link
Member

maelvls commented Sep 5, 2023

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@jetstack-bot jetstack-bot merged commit 0ef97ce into cert-manager:master Sep 5, 2023
4 checks passed
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelvls maelvls maelvls requested changes

@inteon inteon inteon left review comments

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flmmartins @jetstack-bot @maelvls @inteon