duplicate events

[aaronkaplan]

Something looks broken.

[sebix]

status update: it's not the squelcher, it's something other, probably core-related.

[sebix]

Update: two instances of the same bot have been running leading to race conditions (both are reading from the same internal queue)

[aaronkaplan]

On 19 Oct 2016, at 11:28, Sebastian notifications@github.com wrote:

Update: two instances of the same bot have been running leading to race conditions (both are reading from the same internal queue)

But shouldn't the push and pop in redis be atomic?

[sebix]

It is. But we don't do pushs and pops in the internal queue. This internal queue is created per bot-id, not per process!

[aaronkaplan]

On 19 Oct 2016, at 13:55, Sebastian notifications@github.com wrote:

It is. But we don't do pushs and pops in the internal queue. This internal queue is created per bot-id, not per process!

got it. I see. And the internal one is not atomic due to it's different purpose. Sigh.

I think this sounds like we need a two-phase commit that a particular event in the internal queue was handled properly and can be released again.

[sebix]

Fix: certtools#763

Leaving this open until merged