-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--expand not properly documented. #3664
Comments
Yes you can use
In this case, Certbot would create a new directory in Honestly, the |
tagging @pconrad-fb who might want to add documentation for this in his lineage docuementation |
No this isn't closable, however, it's just about changing the help for |
got it - opened a PR |
it's #4495 |
Fixed in #4495. |
Looking at the doc, I see the following for --expand:
Should I add the following: "With the ? |
@bmw thoughts? |
Yep. SGTM! |
@pconrad-fb if you want to make a PR with that change I'd be happy to review and merge it :D |
I'm looking at the docs, and it seems like you can use -d with a comma-delimited list of domains. Is this true? I'd like to put an example in the docs, because I think the behavior is confusing. Which of the following, if any, is correct? certbot -renew --expand -d existing.com,example.com,newdomain.com certbot -renew --expand -d existing.com -d example.com -d newdomain.com certbot --expand -d existing.com,example.com,newdomain.com certbot --expand -d existing.com -d example.com -d newdomain.com |
If you run either of these commands, you get:
These commands are equivalent though. |
- adding what.rst to index.rst - Bigger link to instruction generator in intro.rst, some edits to what.rst in response to comments on What is a Certificate? section first draft #4370 - Responding to St_Ranger's comment on 4370 - Edits to using.rst related to --expand - Initial edit pass through challenges.rst - Edits to what.rst and challenges.rst to resolve #3664 and #4153 - Incorpoprating feedback from #4370 - Finally going after those last few comments before the restructuring of the plugin stuff (coming soon) - Fixing --expand example in using.rst and adding to Apache/NGINX bullet in challenges.rst
From the docs:
Existing certificate has:
example.com
andwww.example.com
.Works:
letsencrypt-auto --expand --force-renewal certonly -d example.com -d test.example.com -d www.example.com
Doesn't work:
letsencrypt-auto --expand certonly -d example.com -d test.example.com
Note that there are 2 differences between these commands:
--force-renewal
, I replicated what I used to get it to work; but this is a prod server so I'm hesitant to retry and risk getting rate limited.The issue is that 2 should not be a problem according to docs. Even more so, expanding should always expand if any certificate exists. "If an existing certificate covers some subset of the requested names...", the empty subset is always covered and requested. Also what if an existing certificate covers a superset of the requested names ("covers" to me suggests that would be fine)? It should then expand and add the newly requested domains.
In conclusion:
The text was updated successfully, but these errors were encountered: