upgrade dependencies #9892
Labels
priority: high
Issues that should be included in the current milestone if at all possible.
Comments
bmw
added
the
priority: high
Merged
bmw
added a commit
that referenced
this issue
Feb 8, 2024
Fixes #9892 and https://github.com/certbot/certbot/security/dependabot Upgrading the base docker image has been done in previous PRs like #9415. Doing this was needed because the [newer versions of `cryptography` need a newer version of rust](https://dev.azure.com/certbot/certbot/_build/results?buildId=7451&view=logs&j=fdd3565a-f3c6-5154-eca9-9ae03666f7bd&t=5dbd9851-46a4-524f-73a8-4028241afcde&l=475). I ran the full test suite on this branch which you can see in the GitHub status checks below. The boulder tests should fail as they're to be fixed by #9889 but everything else should pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's probably fine, but we may want to upgrade dependencies to fix https://github.com/certbot/certbot/security/dependabot. My personal feeling is it's always better to just upgrade than to try and convince ourselves the problems don't affect us.
Repinning things is easy enough, but then we hit problems trying to build
cryptographyin our docker images. OK! To fix that I upgraded our base docker image to a newer one like we've done before in PRs like #9415.Unfortunately, with this change
cryptographytakes (maybe literally) forever to build. (Looking at previous successful nightly builds, that job normally only takes about an hour.)I tried upgrading things a little less aggressively at https://dev.azure.com/certbot/certbot/_build/results?buildId=7464&view=results. We'll see what happens 🤞
The text was updated successfully, but these errors were encountered: