Upgrade base docker image #9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzorin
approved these changes
Sep 26, 2022
|
Docker images created by the full test suite end up as "artifacts" of the CI run that created them, but they're not published anywhere else. |
bmw
added a commit
that referenced
this pull request
Feb 8, 2024
Fixes #9892 and https://github.com/certbot/certbot/security/dependabot Upgrading the base docker image has been done in previous PRs like #9415. Doing this was needed because the [newer versions of `cryptography` need a newer version of rust](https://dev.azure.com/certbot/certbot/_build/results?buildId=7451&view=logs&j=fdd3565a-f3c6-5154-eca9-9ae03666f7bd&t=5dbd9851-46a4-524f-73a8-4028241afcde&l=475). I ran the full test suite on this branch which you can see in the GitHub status checks below. The boulder tests should fail as they're to be fixed by #9889 but everything else should pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test failures last night caused by #9412. The problem was our rust version was too old which is fixed by upgrading our Docker images.
I also opened #9414 to try to help avoid problems like this slipping through in the future. I ran a combination of these two PRs testing the problematic builds at https://dev.azure.com/certbot/certbot/_build/results?buildId=5874&view=results.