Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ./pep8.travis.sh run cleanly #1057

Merged
merged 1 commit into from
Oct 21, 2015
Merged

Make ./pep8.travis.sh run cleanly #1057

merged 1 commit into from
Oct 21, 2015

Conversation

mrwacky42
Copy link
Contributor

98% whitespace.

@bmw
Copy link
Member

bmw commented Oct 21, 2015

LGTM! Thank you for the PR @mrwacky42.

bmw added a commit that referenced this pull request Oct 21, 2015
@bmw
Merge pull request #1057 from mrwacky42/pep8-cleanup
368b69f 
Make ./pep8.travis.sh run cleanly
@bmw bmw merged commit 368b69f into certbot:master Oct 21, 2015
@mrwacky42
Copy link
Contributor Author

Dumb question @bmw, but shouldn''t Travis/Tox have been failing before this PR was merged? How did it get this way?

@mrwacky42 mrwacky42 deleted the pep8-cleanup branch October 21, 2015 05:40
@bmw
Copy link
Member

bmw commented Oct 21, 2015

Not a dumb question at all. Some members of our team felt that running pep8 slowed down development progress and forced us to base our aesthetic decisions on those preferred by a linter. Because of this, pep8 is ran during our normal tests but errors are not considered a testing failure. Some of our developers make sure that all of their code passes the tests, while others ignore it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrwacky42 @bmw