New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run Let's Encrypt on host-system with running containers inside [needs revision] #2196

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kharkevich

kharkevich commented Jan 15, 2016

System with OpenVZ, Virtuozzo, Docker is affected

In case with some software runned in container and listen required port

kharkevich added some commits Jan 15, 2016

Fix run Let's Encrypt on host-system with running containers (OpenVZ,…
… Virtuozzo, Docker, Hadoop, Kubernetes, LXC, Mesos и CoreOS)

In case with some software runned in container and lisen 80 or 443 port
 Changes to be committed:
	modified:   letsencrypt/plugins/util.py
Update util.py
 Changes to be committed:
	modified:   letsencrypt/plugins/util.py
@kharkevich

This comment has been minimized.

kharkevich commented Jan 15, 2016

Errors in travis-ci is not related to my changes

@kharkevich

This comment has been minimized.

kharkevich commented Feb 3, 2016

Fix for #1515

@bmw

This comment has been minimized.

Contributor

bmw commented Feb 12, 2016

Looking at Travis failures, I believe they are related to the changes in this PR. All failures are lint/unit test failures against util.py, the file modified in this PR.

@bmw bmw changed the title from Fix run Let's Encrypt on host-system with running containers inside to Fix run Let's Encrypt on host-system with running containers inside [needs revision] Feb 12, 2016

@bmw

This comment has been minimized.

Contributor

bmw commented Jun 15, 2016

This PR was marked as "needs revision" back in February and hasn't seen any updates. Due to this, I'm closing this issue, but if you'd like us to reconsider, please fix test failures and open a new PR.

@bmw bmw closed this Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment