Fix run Let's Encrypt on host-system with running containers inside [needs revision] #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2016 17:21
… Virtuozzo, Docker, Hadoop, Kubernetes, LXC, Mesos и CoreOS) In case with some software runned in container and lisen 80 or 443 port Changes to be committed: modified: letsencrypt/plugins/util.py
Changes to be committed: modified: letsencrypt/plugins/util.py
|
Errors in travis-ci is not related to my changes |
|
Fix for #1515 |
|
Looking at Travis failures, I believe they are related to the changes in this PR. All failures are lint/unit test failures against |
bmw
changed the title
|
This PR was marked as "needs revision" back in February and hasn't seen any updates. Due to this, I'm closing this issue, but if you'd like us to reconsider, please fix test failures and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System with OpenVZ, Virtuozzo, Docker is affected
In case with some software runned in container and listen required port