-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certbot-auto: Print link to doc on debugging pip install error [revision requested] #3473
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf71a47
certbot-auto: Print link to doc on debugging pip install error
timdream b3d20aa
Correct formatting
timdream 643aa70
grep the PIP_OUT and print useful info if the problem is about memory…
timdream 93f0b02
Merge remote-tracking branch 'upstream/master' into doc-on-venv-memory
timdream 2b0ee98
Fix logic on string to grep
timdream c661112
Merge remote-tracking branch 'upstream/master' into doc-on-venv-memory
timdream File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we grep "$PIP_OUT" for the relevant error strings, so that we're only printing the hint about swap space if that's the actual error the user encountered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which string 😝?
internal compiler error: Killed (program cc1)
could happen because of other reasons. I don't feel particularly good to make unreliable guesses.I can
grep
that if you think that is the right string to grep.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconveniently, the error can crop up in a bunch of different ways, depending on which exact step the compilation gets to, and whether it's a specific compilation step that fails, or the kernel's OOM killer that steps in and breaks something. Here are a few different examples I've seen. These are all on DO droplets, using
stress
to simulate low memory conditions (since apparently 512MB is now typically enough to runcertbot-auto
, which is nice :)Ubuntu 16.04, 26MB available:
CentOS 6.8 (31MB free)
CentOS 6.x, ~100MB free:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe we should grep for the strings
Killed
andallocate memory
, and print information suggesting that this might be the problem, and how to fix it, in those cases?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just recreated the problem on my DO droplet again. On Ubuntu it does not seems to print
allocate memory
, justKilled
.@pde Should we grep for
Killed
_or_allocate memory
?