Automatically retry after getting badNonce error #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged not squashed to give credit to the patch from #2244. |
ohemorange
approved these changes
Jan 26, 2017
| except messages.Error as error: | ||
| if should_retry and error.code == 'badNonce': | ||
| logger.debug('Retrying request after error:\n%s', error) | ||
| should_retry = False |
There was a problem hiding this comment.
if we're only trying once, we cooould just put self._post_once right in the except. this should be fine though.
|
lgtm! |
|
Awesome. Thanks for the review guys. I agree with you on the just call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2244 and fixes #4099.