Save hyphenated plugin params for renewal (#4281) #4395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix plugin namespace check * Add test to prevent regressions (cherry picked from commit b7d2823)
|
This commit has only been out for a few days. The bug has been around for roughly forever I think? I personally don't think it meets the bar for cherry picking, but I'm fine as long as you want to babysit it. I'll approve and let you decide. |
ohemorange
approved these changes
Mar 22, 2017
|
That's a fair point. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix plugin namespace check
Add test to prevent regressions
(cherry picked from commit b7d2823)