Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence spammy integration test cases. #5934

Merged
merged 3 commits into from Sep 12, 2018
Merged

Silence spammy integration test cases. #5934

merged 3 commits into from Sep 12, 2018

Conversation

jsha
Copy link
Contributor

@jsha jsha commented May 9, 2018

No description provided.

@ohemorange
Copy link
Contributor

Thanks for making this change!

Few things:

  • assigning a reviewer means we see PRs, and not just months later when we do a cleanup
  • since then, we've moved the relevant code to a different file. probably easier to redo than try to do some merging.
  • space before and after operator plz: command > /dev/null

@jsha
Copy link
Contributor Author

jsha commented Sep 12, 2018

Updated to use the new file, and made the whitespace change. Thanks for the review!

ohemorange
ohemorange approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@ohemorange ohemorange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful thanks!!

@jsha jsha merged commit 8f7209d into master Sep 12, 2018
@jsha jsha deleted the quiet-please branch September 12, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohemorange ohemorange ohemorange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsha @ohemorange