Add a test to ensure test coverage regardless of the vhost order #6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmw
requested changes
Mar 25, 2019
| @@ -1521,6 +1522,29 @@ def test_add_vhost_id_already_exists(self): | |||
| second_id = self.config.add_vhost_id(self.vh_truth[0]) | |||
| self.assertEqual(first_id, second_id) | |||
|
|
|||
| def test_realpath_replaces_symlink(self): | |||
| orig_match = self.config.aug.match | |||
| mock_vhost = copy.copy(self.vh_truth[0]) | |||
There was a problem hiding this comment.
nit: Can we use copy.deepcopy so things like the alias attribute don't refer to the same object?
|
Now that #6880 has been resolved, we should be able to bump the minimum coverage in the Apache plugin back to 100% in this PR as well. |
|
The coverage requirement is back at 100% now. I wasn't sure if we should add changelog entry for a purely test related PR, so I skipped doing so. |
bmw
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
I wasn't sure if we should add changelog entry for a purely test related PR, so I skipped doing so.
I think that's the right call. The way I think about it is if it's something our users or packagers should care about and in this case I don't think it is. It's mainly for devs.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new test to make sure that we are covering all the branches of
get_virtual_hosts()regardless of the order that Augeas returns the foundVirtualHostpaths.Fixes: #6813