-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unpinned dependencies tests towards botocore and urllib3 #7081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in certbot-dns-route53 throught botocore dependency.
Relevant nightly build can be seen here: https://travis-ci.com/certbot/certbot/builds/112210832 |
Whoever ends up resolving pypa/pip#988 instantly becomes one of my favorite people. (@adferrand, try not to let this comment nerdsnipe you 😝 I think it's a big and fairly political task.) What I think we should do here is this:
What do you think? |
bmw
reviewed
May 17, 2019
bmw
reviewed
May 17, 2019
bmw
reviewed
May 17, 2019
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
I added #7083 to track revert on this PR. |
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
bmw
approved these changes
May 17, 2019
adferrand
pushed a commit
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently unpinned dependencies tests are failing, see latest Travis nightly run: https://travis-ci.com/certbot/certbot/builds/112182519
This is because:
requests
has been released yesterday (2.22.0
), and it relax its transitive dependency fromurllib<1.25
tourllib<1.26
botocore
in the route53 certbot dns plugin still requiresurllib<1.25
Several issues have been raised in
botocore
project about this, with one issue tracking down the update ofurllib3
dependency inbotocore
: boto/botocore#1733So hopefully
botocore
will be update before our next release, but nonetheless I make a PR here to fix the situation until that, by capping our own transitive dependency forurllib3
to<1.25
. I prefer doing that instead of cappingrequests
version, because it still compatible withurllib3
1.24.x branch, and we should keep the benefit of the latest improvements inrequests
.Once
botocore
is updated, this PR should be reverted.