Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unpinned dependencies tests towards botocore and urllib3 #7081

Merged
merged 7 commits into from
May 17, 2019

Conversation

adferrand
Copy link
Collaborator

Currently unpinned dependencies tests are failing, see latest Travis nightly run: https://travis-ci.com/certbot/certbot/builds/112182519

This is because:

  1. New version of requests has been released yesterday (2.22.0), and it relax its transitive dependency from urllib<1.25 to urllib<1.26
  2. Current version of botocore in the route53 certbot dns plugin still requires urllib<1.25

Several issues have been raised in botocore project about this, with one issue tracking down the update of urllib3 dependency in botocore: boto/botocore#1733

So hopefully botocore will be update before our next release, but nonetheless I make a PR here to fix the situation until that, by capping our own transitive dependency for urllib3 to <1.25. I prefer doing that instead of capping requests version, because it still compatible with urllib3 1.24.x branch, and we should keep the benefit of the latest improvements in requests.

Once botocore is updated, this PR should be reverted.

…ts in certbot-dns-route53 throught botocore dependency.
@adferrand adferrand requested review from bmw May 17, 2019 10:41
@adferrand
Copy link
Collaborator Author

Relevant nightly build can be seen here: https://travis-ci.com/certbot/certbot/builds/112210832

@bmw
Copy link
Member

bmw commented May 17, 2019

Whoever ends up resolving pypa/pip#988 instantly becomes one of my favorite people. (@adferrand, try not to let this comment nerdsnipe you 😝 I think it's a big and fairly political task.)

What I think we should do here is this:

  1. Pin back urllib3 in certbot-dns-route53/setup.py with a comment explaining that this is needed to make installation work with pip due to pip needs a dependency resolver pypa/pip#988, allow the use of urllib3 1.25.x boto/botocore#1733, and pip preferring the newest version of all dependencies. I'd also say that if allow the use of urllib3 1.25.x boto/botocore#1733 has been resolved, the dependency on urllib3 specified here can be safely removed. I think the fix should go in the route53 plugin since that is the only component affected and the comment is useful to describe what is going on to package maintainers who may need to fix this up on their end.
  2. Create an issue in the current milestone for us to remove this pinning with a link to the boto3 botocore issue.

What do you think?

This reverts commit 7f30445.
Revert "Limit transitive dependency on urllib3 to <1.25 to fulfill requirements in certbot-dns-route53 throught botocore dependency."

This reverts commit da7d747.
certbot-dns-route53/setup.py Outdated Show resolved Hide resolved
certbot-dns-route53/setup.py Outdated Show resolved Hide resolved
certbot-dns-route53/setup.py Outdated Show resolved Hide resolved
adferrand and others added 2 commits May 17, 2019 21:41
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
@adferrand
Copy link
Collaborator Author

I added #7083 to track revert on this PR.

Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants