[Windows] Ensure relpath is executed between paths in the same drive #7335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows you can have several drives (
C:
,D:
, ...), that is the roughly (really roughly) equivalent of mount points, since each drive is usually associated to a specific physical partition.So you can have paths like
C:\one\path
,D:\another\path
.In parallel,
os.path.relpath(path, start='.')
calculates the relative path between the givenpath
and astart
path (current directory if not provided). In recent versions of Python,os.path.relpath
will fail ifpath
andstart
are not on the same drive, because a relative path between two paths likeC:\one\path
,D:\another\path
is not possible.In saw unit tests failing because of this in two locations. This occurs when the certbot codebase that is tested is on a given drive (like
D:
) while the default temporary directory used bytempfile
is on another drive (most of the time located inC:
drive).This PR fixes that.