Skip to content

Commit

Permalink
it is called 'mongoDB' and not 'Mongo DB'
Browse files Browse the repository at this point in the history
  • Loading branch information
@aaronkaplan
aaronkaplan committed Jul 25, 2016
1 parent ece75ea commit 1973105
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions intelmq/bots/parsers/shadowserver/config.py
View file
Expand Up @@ -51,7 +51,7 @@ def get_feed(feedname):
"DNS-open-resolvers": dns_open_resolvers, # TODO Check implementation.
"Open-Elasticsearch": open_elasticsearch,
"Open-NetBIOS": open_net_bios, # TODO Check implementation.
"Open-Mongo DB": open_mongo_db, # TODO Check implementation.
"Open-MongoDB": open_mongodb, # TODO Check implementation.
"Open-MSSQL": open_mssql, # TODO Check implementation.
"Open-SNMP": open_snmp,
"Open-SSDP": open_ssdp, # TODO Check implementation.
Expand Down Expand Up @@ -565,7 +565,7 @@ def validate_ip(value):
}

# https://www.shadowserver.org/wiki/pmwiki.php/Services/Open-MongoDB
open_mongo_db = {
open_mongodb = {
'required_fields': [
('time.source', 'timestamp', add_UTC_to_timestamp),
('source.ip', 'ip'),
Expand Down

5 comments on commit 1973105

@dmth
Copy link
Contributor

@dmth dmth commented on 1973105 Jul 27, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feed name is the headline of the page in shadowserver documention which is "Open-Mongo DB".
That is also documented in the readme of this parser.

Sorry to say, but this change and the one on "Net Bios" are simply wrong. It even broke things at our place.

boromir

@aaronkaplan
Copy link
Member Author

@aaronkaplan aaronkaplan commented on 1973105 Jul 27, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but otherwise you would not even be consistent within the file.
Sorry... this is what we need to do. The changes were right. Sorry to say that.
And the product is called "mongoDB" - spelled exactly like that.

@aaronkaplan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also another comment: until we have release 1.0 things might break with commits.
That's how it is. Fixes to release 1.0 MUST have backwards compatibility. But until then, we are on a development branch de facto. Things break on development branches.

@dmth
Copy link
Contributor

@dmth dmth commented on 1973105 Jul 27, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but otherwise you would not even be consistent within the file.

That's not a problem, as the names are documented. How these are created was plausible, until your change.

And the product is called "mongoDB" - spelled exactly like that.

The product might be called that way, the Shadowserver feed however is not. See
https://www.shadowserver.org/wiki/pmwiki.php/Services/Open-MongoDB

Also another comment: until we have release 1.0 things might break with commits.

If you know things will break, (for instance when renaming keys) please communicate louder.
In general. "Master" should not be a development branch.

@aaronkaplan
Copy link
Member Author

@aaronkaplan aaronkaplan commented on 1973105 Jul 27, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.