rename snmp to opensnmp for classification.identifier. Fixes #657

certtools · Oct 5, 2016 · bc7c0ca · bc7c0ca
1 parent 4fec8d1
commit bc7c0ca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/intelmq/bots/parsers/shadowserver/config.py b/intelmq/bots/parsers/shadowserver/config.py
@@ -543,7 +543,7 @@ def validate_ip(value):
         'classification.type': 'vulnerable service',
         'classification.taxonomy': 'Vulnerable',
         'protocol.application': 'snmp',
-        'classification.identifier': 'snmp',
+        'classification.identifier': 'opensnmp',
         'feed.code': 'shadowserver-opensnmp',
         'feed.name': 'shadowserver',
     },

diff --git a/intelmq/tests/bots/parsers/shadowserver/test_snmp.py b/intelmq/tests/bots/parsers/shadowserver/test_snmp.py
@@ -22,7 +22,7 @@
                   "time.observation": "2015-01-01T00:00:00+00:00",
                   }
 EVENTS = [{'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "Hardware: x86 Family 6 Model 8 Stepping 6 AT/AT COMPATIBLE - Software: Windows 2000 Version 5.0 (Build 2195 Uniprocessor Free)", "sysname": "ORSONKA", "version": 2}',
@@ -42,7 +42,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:50+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "ADSL Modem", "sysname": "tc", "version": 2}',
@@ -62,7 +62,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"version": 2}',
@@ -82,7 +82,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "Linux ADSL2PlusRouter 2.6.19 #7 Tue Apr 9 17:06:16 CST 2013 mips", "sysname": "TD5130", "version": 2}',
@@ -102,7 +102,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "Linux R6100 2.6.31 #1 Tue Jun 4 06:50:58 EDT 2013 mips MIB=01a01", "sysname": "Unknow", "version": 2}',
@@ -122,7 +122,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "110TC1", "sysname": "Beetel", "version": 2}',
@@ -142,7 +142,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "BCW710J <<HW_REV: 1.01; VENDOR: Bnmux; BOOTR: 2.4.0alpha14; SW_REV: 5.30.5; MODEL: BCW710J>>", "sysname": "CableHome", "version": 2}',
@@ -162,7 +162,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "Linux WNR1000v2 2.6.15 #199 Thu Jan 28 09:49:57 CST 2010 mips MIB=01a01", "sysname": "Unknow", "version": 2}',
@@ -182,7 +182,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"version": 2}',
@@ -201,7 +201,7 @@
            'time.observation': '2015-01-01T00:00:00+00:00',
            'time.source': '2014-03-16T03:45:51+00:00'},
           {'__type': 'Event',
-           'classification.identifier': 'snmp',
+           'classification.identifier': 'opensnmp',
            'classification.taxonomy': 'Vulnerable',
            'classification.type': 'vulnerable service',
            'extra': '{"sysdesc": "D-Link Wireless Voice Gateway <<HW_REV: B4; VENDOR: D-Link; BOOTR: 2.4.0beta1; SW_REV: 1.1.0.4; MODEL: DCM-704>>", "sysname": "CableHome", "version": 2}',