Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing FQDN-Validation #1030

Closed
dmth opened this issue Jun 30, 2017 · 0 comments
Closed

Failing FQDN-Validation #1030

dmth opened this issue Jun 30, 2017 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior data-format
Milestone
1.0.0

Comments

@dmth
Copy link
Contributor

dmth commented Jun 30, 2017

FQDN-Validation fails with an exception, if the domain starts with a . character.

Details and ways to reproduce are mentioned in
#1022 (comment)

This issue aims for a universal solution of this problem, whilst the aforementioned #1022 tries to resolve the shadowserver-parser specific problem.
@dmth dmth mentioned this issue Jun 30, 2017
Closed
@ghost ghost added this to the v1.0 Stable Release milestone Jul 4, 2017
@ghost ghost added bug Indicates an unexpected problem or unintended behavior data-format labels Jul 4, 2017
dmth pushed a commit to Intevation/intelmq that referenced this issue Jul 6, 2017
Bugfix: Strip leading dots from FQDN in Shadowserver config
ea48fa1 
Extends the validate_fqdn method by removing trailing dots from
the fqdn.
This fixes certtools#1022 on the
shadowserver-parser config level.

All "hostname" carrying values are now validated using this function.

Nevertheless this issue should still be discussed as it is present for all
other feeds. See certtools#1030 for the
general solution.
@dmth dmth mentioned this issue Jul 6, 2017
Closed
dmth pushed a commit to Intevation/intelmq that referenced this issue Jul 6, 2017
Bugfix: Strip leading dots from FQDN in Shadowserver config
7c8b736 
Extends the validate_fqdn method by removing trailing dots from
the fqdn.
This fixes certtools#1022 on the
shadowserver-parser config level.

All "hostname" carrying values are now validated using this function.

Nevertheless this issue should still be discussed as it is present for all
other feeds. See certtools#1030 for the
general solution.
@ghost ghost closed this as completed in ab3b31e Jul 6, 2017
ghost pushed a commit that referenced this issue Jul 6, 2017
BUG: FQDN: handle leading dots
c24bb06 
fixes #1022
fixes #1030
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior data-format
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@dmth