Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase flexibility of the installer #181

Closed
5 tasks done
Rafiot opened this issue May 24, 2015 · 12 comments
Closed
5 tasks done

Increase flexibility of the installer #181

Rafiot opened this issue May 24, 2015 · 12 comments
Assignees
Labels
feature Indicates new feature requests or new features packaging
Milestone

Comments

@Rafiot
Copy link
Member

Rafiot commented May 24, 2015

This is not really a bug, just me looking at the installer and taking some notes.. :)

  • I like being able to install projects in my home directory, I'm not sure how the project will like it, so I stick to the /opt/ way for now, and will look at it later (seems that the only hard coded paths are the config files, which makes total sense). Same as running an install script as root, me not liking it. (related to 2.)
  • I always install python projects in a virtualenv (so I do not pollute the rest of the system with pip packages). And I can have multiple projects running at once on the same bare system without having random issues with updates. That seems to work, updates to come in case it doesn't.
  • Upgrade: a requirements.txt file with the list of dependencies would a be nice to have, so it is possible to update them (and only them) more easily.
  • Uninstall: that should never be done on a bare machine with other services installed, or I'm pretty sure they will be broken.
  • I assumes you have one single redis instance installed system wide, on the default port. In our infrastructure, we will have tons of redis instances running on the same host. Would be a good idea to not start polluting redis instances that may be running on the same host by mistake.
@Rafiot Rafiot self-assigned this May 24, 2015
@SYNchroACK
Copy link
Contributor

Hi @Rafiot , if you have time, check the new version that is under developments.

https://github.com/certtools/intelmq-beta

@Rafiot
Copy link
Member Author

Rafiot commented May 26, 2015

Hi @SYNchroACK, thank you, I will.
Just a practical question: why not just using a dev branch on the main project for the future release? it would be much easier to follow the differences.

@aaronkaplan
Copy link
Member

On May 26, 2015, at 8:23 AM, Raphaël Vinot notifications@github.com wrote:

Hi @SYNchroACK, thank you, I will.
Just a practical question: why not just using a dev branch on the main project for the future release? it would be much easier to follow the differences.

Yeah, I asked the same. Seems the -beta repo will be deleted after successful merging into the main master tree.


Reply to this email directly or view it on GitHub.

@Rafiot
Copy link
Member Author

Rafiot commented May 26, 2015

Well, that's why branches are there :)

@aaronkaplan
Copy link
Member

On May 26, 2015, at 11:26 AM, Raphaël Vinot notifications@github.com wrote:

Well, that's why branches are there :)

I agree..

@SYNchroACK
Copy link
Contributor

@Rafiot , beta version has zmq support .... lib/pipeline.py
intelmqctl etc need some improvements to support it...

@Rafiot
Copy link
Member Author

Rafiot commented May 27, 2015

Ok. I'm not sure it is interesting for you, but his is the way I implemented the redis & ZMQ support for AIL: https://github.com/CIRCL/AIL-framework/blob/master/bin/Helper.py

@SYNchroACK
Copy link
Contributor

Thanks

@SYNchroACK
Copy link
Contributor

This is not really a bug, just me looking at the installer and taking some notes.. :)

1 - I like being able to install projects in my home directory, I'm not sure how the project will like it, so I stick to the /opt/ way for now, and will look at it later (seems that the only hard coded paths are the config files,
which makes total sense). Same as running an install script as root, me not liking it. (related to 2.)

In the new version, v1.0-beta branch, the init.py file in intelmq root is the only place where the PATHs are defined. In your custom installation you need to change it there and also the setup.py. If you see an opportunity to improve it, please, send a pull req. :)

2 - I always install python projects in a virtualenv (so I do not pollute the rest of the system with pip packages). And I can have multiple projects running at once on the same bare system without having random issues with updates.
That seems to work, updates to come in case it doesn't.

Thanks for the feedback.

3 - Upgrade: a requirements.txt file with the list of dependencies would a be nice to have, so it is possible to update them (and only them) more easily.

v1.0-beta branch it has REQUIREMENTS file since you suggest the idea ;)

4 - Uninstall: that should never be done on a bare machine with other services installed, or I'm pretty sure they will be broken.

:( dont know how to solve it in case of user need to uninstall without broke anything.

5 - It assumes you have one single redis instance installed system wide, on the default port. In our infrastructure, we will have tons of redis instances running on the same host. Would be a good idea to not start polluting redis
instances that may be running on the same host by mistake.

v1.0-beta branch we are trying to improve it.

@SYNchroACK SYNchroACK added the feature Indicates new feature requests or new features label Jun 6, 2015
@SYNchroACK SYNchroACK added this to the Release 3 milestone Jun 6, 2015
@SYNchroACK
Copy link
Contributor

This is not really a bug, just me looking at the installer and taking some notes.. :)

.

1 - I like being able to install projects in my home directory, I'm not sure how the project will like it, so I stick to the /opt/ way for now, and will look at it later (seems that the only hard coded paths are the config files,
which makes total sense). Same as running an install script as root, me not liking it. (related to 2.)

In the new version, v1.0-beta branch, the init.py file in intelmq root is the only place where the PATHs are defined. In your custom installation you need to change it there and also the setup.py. If you see an opportunity to
improve it, please, send a pull req. :)

v1.0-beta branch was merged with master branch. :)

2 - I always install python projects in a virtualenv (so I do not pollute the rest of the system with pip packages). And I can have multiple projects running at once on the same bare system without having random issues with updates.
That seems to work, updates to come in case it doesn't.

Thanks for the feedback.

.

3 - Upgrade: a requirements.txt file with the list of dependencies would a be nice to have, so it is possible to update them (and only them) more easily.

v1.0-beta branch it has REQUIREMENTS file since you suggest the idea ;)

v1.0-beta branch was merged with master branch. :)

4 - Uninstall: that should never be done on a bare machine with other services installed, or I'm pretty sure they will be broken.

:( dont know how to solve it in case of user need to uninstall without broke anything.

Until now, any news about it. :(

5 - It assumes you have one single redis instance installed system wide, on the default port. In our infrastructure, we will have tons of redis instances running on the same host. Would be a good idea to not start polluting redis
instances that may be running on the same host by mistake.

v1.0-beta branch we are trying to improve it.

Master branch has now the correct approach. (I hope :P)

@sebix
Copy link
Member

sebix commented Mar 1, 2016

Most issues have been solved in #448 and #391 and #451

Still unresolved: usage of multiple intelmq-instances on one redis-instance

@sebix
Copy link
Member

sebix commented May 24, 2016

I think i misunderstood the last point. It's about configuring the redis port (which has been implemented "long" ago).

Closing this, everything is done. If not, please reopen or open another issue and explain in more detail.

@sebix sebix closed this as completed May 24, 2016
@ghost ghost modified the milestones: v2.0 Release, v1.0 Stable Release Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates new feature requests or new features packaging
Projects
None yet
Development

No branches or pull requests

4 participants