Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowserver Parser can't differentiate between "Accessible HTTP" and "Vulnerable HTTP" #1984

Closed
ghost opened this issue Jun 9, 2021 · 1 comment · Fixed by #2037
Closed
Labels
bug Indicates an unexpected problem or unintended behavior component: bots

Comments

@ghost
Copy link

ghost commented Jun 9, 2021

See #1971 (comment) and #1971 (comment)

The two feeds Accessible HTTP Report and Vulnerable HTTP Report use the same file name scan_http. Our feed detection is solely based on the file name and detects now Vulnerable-HTTP. Fortunately, the columns are identical, but this still causes a wrong feed name to be added to the data, of the file is actually from the Accessible-HTTP feed. Shadowserver's docs say, that the tag column is always http for the Accessible HTTP feed, so the data is still differentiable maybe?

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Jun 9, 2021
@monoidic
Copy link
Contributor

monoidic commented Jun 9, 2021

Slight correction:

Our feed detection is solely based on the file name

You can match by feed name as well, and if this is done, then they are differentiated. This is only a problem if the feeds are matched by filename.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant