Support Shadowserver Vulnerable SMTP server feed, fix #1984 #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2037 +/- ##
===========================================
- Coverage 75.98% 75.95% -0.04%
===========================================
Files 423 427 +4
Lines 22812 22973 +161
Branches 3040 3060 +20
===========================================
+ Hits 17334 17448 +114
- Misses 4772 4817 +45
- Partials 706 708 +2
|
ghost
added
bug
ghost
suggested changes
Aug 13, 2021
Co-authored-by: Wagner <wagner+github@cert.at>
ghost
reviewed
Aug 13, 2021
| @@ -2862,8 +2888,9 @@ def scan_exchange_identifier(field): | |||
| ('Sinkhole-Events-HTTP-Referer IPv6', 'event6_sinkhole_http_referer', event46_sinkhole_http_referer), | |||
| ('Spam-URL', 'spam_url', spam_url), | |||
| ('Vulnerable-ISAKMP', 'scan_isakmp', vulnerable_isakmp), | |||
| ('Vulnerable-HTTP', 'scan_http', accessible_vulnerable_http), | |||
| ('Vulnerable-HTTP', 'scan_http_vulnerable', accessible_vulnerable_http), | |||
|
The suggested improvement reminded me of #1984, so I also fixed that by making Vulnerable-HTTP match by |
monoidic
changed the title
yeah, me too - but only after you committed the other fix :)
Thanks! Didn't think that #1984 is based on such a simple mistake. |
ghost
approved these changes
Aug 13, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Shadowserver Vulnerable SMTP Report and fixes #1984 by differentiating between Vulnerable-HTTP and Accessible-HTTP filenames.